From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roland Dreier <rdreier@cisco.com>
Subject: Re: [PATCH] LogFS take three
Date: Tue, 15 May 2007 19:37:36 -0700
Message-ID: <adar6pho5n3.fsf@cisco.com>
References: <20070515151919.GA32510@lazybastard.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-mtd@lists.infradead.org, akpm@osdl.org,
	Albert Cahalan <acahalan@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jan Engelhardt <jengelh@linux01.gwdg.de>,
	Evgeniy Polyakov <johnpol@2ka.mipt.ru>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Greg KH <greg@kroah.com>, Ingo Oeser <ioe-lkml@rameria.de>
To: =?iso-8859-1?Q?J=C3=B6rn?= Engel <joern@lazybastard.org>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from sj-iport-3-in.cisco.com ([171.71.176.72]:52011 "EHLO
	sj-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755531AbXEPCiD (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 15 May 2007 22:38:03 -0400
In-Reply-To: <20070515151919.GA32510@lazybastard.org> (=?iso-8859-1?Q?J=C3?=
 =?iso-8859-1?Q?=B6rn?= Engel's message of "Tue, 15 May 2007 17:19:20
 +0200")
Sender: linux-fsdevel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

There are rather a lot of of FIXME comments, including scary stuff like

 > +	/*
 > +	 * FIXME: this cannot be right but it does "fix" a bug of i_count
 > +	 * dropping too low.  Needs more thought.
 > +	 */
 > +	atomic_inc(&old_dentry->d_inode->i_count);

and

 > +int __logfs_write_inode(struct inode *inode)
 > +{
 > +	/*
 > +	 * FIXME: Those two inodes are 512 bytes in total.  Not good to
 > +	 * have on the stack.  Possibly the best solution would be to bite
 > +	 * the bullet and do another format change before release and
 > +	 * shrink the inodes.
 > +	 */
 > +	struct logfs_disk_inode old, new;

are you going to change the format?  or fix this some other way?

I think a sweep through the code searching for FIXME and at least
rewriting all such comments to look like stuff that can be deferred
would be warranted ;)

 - R.