From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v3] f2fs: do not support mmap write for large folio
Date: Fri, 10 Apr 2026 01:15:32 +0000 [thread overview]
Message-ID: <adhPNLtbAlqI8F3l@google.com> (raw)
In-Reply-To: <adc7yo1_sr_eeV33@infradead.org>
On 04/08, Christoph Hellwig wrote:
> [adding back fsdevel and mm to the discussion]
>
> On Wed, Apr 08, 2026 at 06:13:06PM +0000, Jaegeuk Kim wrote:
> > Let's check mmap writes onto the large folio, since we don't support writing
> > large folios.
>
> What does this fix? As state in the previous round of discussion f2fs
> only support large folios for immutable files, how do you get ->mkwrite
> called for them.
I'm approaching this as a safeguard first, since in any buggy case, this will
crash the filesystem.
>
> The only way I can think of that is when clearing the immutable flag,
> but simply rejecting writes with SIGBUS after that seems like it's
> breaking the expected API, and I don't see handling for normal writes
> after that either.
prev parent reply other threads:[~2026-04-10 1:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260406154940.2407853-1-jaegeuk@kernel.org>
[not found] ` <adaasm42rLxRY2GN@google.com>
2026-04-09 5:40 ` [PATCH v3] f2fs: do not support mmap write for large folio Christoph Hellwig
2026-04-10 1:15 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adhPNLtbAlqI8F3l@google.com \
--to=jaegeuk@kernel.org \
--cc=hch@infradead.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox