public inbox for linux-fsdevel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Adrian McMenamin <adrianmcmenamin@gmail.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] Add support for VMUFAT filesystem
Date: Fri, 10 Apr 2026 18:53:39 +0100	[thread overview]
Message-ID: <adk5I8RsBjJY3bRM@casper.infradead.org> (raw)
In-Reply-To: <CACwZE5SctP1QAy_5_sBTC--O8ubGwFpFry0KF+CS72W=EXn7Eg@mail.gmail.com>

On Fri, Apr 10, 2026 at 04:37:36PM +0100, Adrian McMenamin wrote:
> On Fri, 10 Apr 2026 at 15:38, Matthew Wilcox <willy@infradead.org> wrote:
> >
> 
> >
> > You should add an extry to Documentation/filesystems/index.rst too.
> >
> 
> That was sent but I had some trouble with it, but you should see it on
> the mailing list now.

I have to say this patch series is almost impossible to review.  I'm
not quite sure what you did, but it feels like you generated these
patches manually and then used git send-email to send them.

What I do is construct a git tree that contains all the patches I want
then generate a series like this:

git format-patch HEAD~4 -o pgtable-20251113 --to 'Andrew Morton <akpm@linux-foundation.org>' --cc 'David Hildenbrand <david@kernel.org>' --cc 'Vishal Moola <vishal.moola@gmail.com>' --cc linux-mm@kvack.org --cover-letter

Then I scp them over to the machine which handles my email and use git
send-email on that machine to send the pgtable-20251113 directory full
of patches. 

The other thing that I'd advise you to be careful to do is make sure the
patch series is properly bisectable -- for example, you're adding the
Kconfig options before the Makefile and the Makefile before the files
that it would make.  I'd invert that order; add all the code, then the
Makefile, then the documentation.


  reply	other threads:[~2026-04-10 17:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 14:24 [PATCH 02/10] Add support for VMUFAT filesystem Adrian McMenamin
2026-04-10 14:38 ` Matthew Wilcox
2026-04-10 15:37   ` Adrian McMenamin
2026-04-10 17:53     ` Matthew Wilcox [this message]
     [not found]       ` <CACwZE5ScnatgFD_VT75m4p4dH=R4biWj2OZKwXkuGrzREi4urg@mail.gmail.com>
2026-04-10 18:12         ` Adrian McMenamin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=adk5I8RsBjJY3bRM@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=adrianmcmenamin@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox