From: Steven Whitehouse <swhiteho@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>,
"Eric W. Biederman" <ebiederm@redhat.com>
Cc: linux-fsdevel@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] mount API series
Date: Thu, 1 Nov 2018 10:53:21 +0000 [thread overview]
Message-ID: <af28fc2c-d207-875e-8070-f64ead878b5a@redhat.com> (raw)
In-Reply-To: <CAHk-=whAE6gVi18=u4sSWe1m2RWPh19YCkKQmW4Kx+NQX1mg8w@mail.gmail.com>
Hi,
On 31/10/18 16:18, Linus Torvalds wrote:
> On Tue, Oct 30, 2018 at 10:34 PM Al Viro <viro@zeniv.linux.org.uk> wrote:
>> mount API series from David Howells. Last cycle's objections
>> had been of the "I'd do it differently" variety and with no such
>> differently done variants having ever materialized over several
>> cycles...
> Having just lurked on the discussions about the bugs in here, I don't
> think this is ready. Maybe they got fixed, but if so, it was recent
> and it was pretty fundamental.
>
> The stated aim of the series is to make the mount API _better_, not
> worse. And right now it looks like a "two steps back, one theoretical
> step forwards" kind of better.
>
> Linus
The design of the new mount API has been under discussion for some time,
both on the mailing lists, and also at LSF/MM too. Al and David (and
others) have put a lot of work into getting to the current position, and
have specifically requested input from Eric about his concerns over past
cycles.
When I look at the discussions I'm seeing two main issues (please
correct me if you think I'm wrong about this) which are (a) whether the
design is correct and (b) whether there are still bugs in the current
patch set.
Which of these are you most concerned about? It seems to me that there
is not a lot of point in spending a large amount of time in additional
review/testing of the current patch set if the overall design is set to
be rejected. If your concerns are only with the robustness/stability of
the patch set, then that provides a clear route to resolving the current
impasse, at least assuming that Eric is able to enumerate the issues
that he has discovered.
It looks like David has already provided a fix for one of the issues
which Eric mentioned in his recent email. Eric it would be good if you
could confirm that this addresses that particular concern,
Steve.
next prev parent reply other threads:[~2018-11-01 19:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 5:33 [git pull] mount API series Al Viro
2018-10-31 15:38 ` Eric W. Biederman
2018-10-31 16:18 ` Eric W. Biederman
2018-10-31 16:36 ` Al Viro
2018-11-01 16:51 ` Al Viro
2018-11-10 14:19 ` Steven Whitehouse
2018-11-12 2:07 ` Eric W. Biederman
2018-11-12 20:54 ` Al Viro
2018-12-17 23:10 ` Al Viro
2018-12-21 16:25 ` Eric W. Biederman
2018-10-31 16:18 ` Linus Torvalds
2018-11-01 10:53 ` Steven Whitehouse [this message]
2018-11-01 15:57 ` Linus Torvalds
2018-11-01 17:18 ` David Howells
2018-11-01 18:33 ` Linus Torvalds
2018-11-01 22:05 ` Al Viro
2018-11-01 22:07 ` Linus Torvalds
2018-11-01 23:59 ` David Howells
2018-11-02 4:07 ` Al Viro
2018-11-02 19:42 ` Al Viro
2018-11-03 6:14 ` Gao Xiang
2018-11-03 6:30 ` Gao Xiang
2018-10-31 18:39 ` David Howells
2018-10-31 20:49 ` Miklos Szeredi
2018-10-31 18:45 ` [PATCH] vfs: Fix incorrect user_ns assignment in proc and mqueue David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af28fc2c-d207-875e-8070-f64ead878b5a@redhat.com \
--to=swhiteho@redhat.com \
--cc=ebiederm@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).