From: Chi Zhiling <chizhiling@163.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: cem@kernel.org, djwong@kernel.org, brauner@kernel.org,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Chi Zhiling <chizhiling@kylinos.cn>
Subject: Re: [PATCH] iomap: Rename iomap_last_written_block to iomap_first_unchanged_block
Date: Thu, 27 Mar 2025 19:46:24 +0800 [thread overview]
Message-ID: <af42c4fb-925a-4c3f-b54e-a07dff8bb168@163.com> (raw)
In-Reply-To: <Z-Up3xt1q9swlhv_@infradead.org>
On 2025/3/27 18:35, Christoph Hellwig wrote:
> On Thu, Mar 27, 2025 at 01:57:06PM +0800, Chi Zhiling wrote:
>> From: Chi Zhiling <chizhiling@kylinos.cn>
>>
>> This renames iomap_last_written_block() to iomap_first_unchanged_block()
>> to better reflect its actual behavior of finding the first unmodified
>> block after partial writes, improving code readability.
>
> Does it? I it used in the context of a write operation where uncached
> is not exactly well define. I'm not a native speaker, but I don't see
> an improvement here (then again I picked the current name, so I might be
> biassed).
Okay, actually 'last_written_block' also makes sense, it's just that it
returns the end of the last written block, not the beginning
thanks,
Chi Zhiling
prev parent reply other threads:[~2025-03-27 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 5:57 [PATCH] iomap: Rename iomap_last_written_block to iomap_first_unchanged_block Chi Zhiling
2025-03-27 10:35 ` Christoph Hellwig
2025-03-27 11:46 ` Chi Zhiling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af42c4fb-925a-4c3f-b54e-a07dff8bb168@163.com \
--to=chizhiling@163.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=chizhiling@kylinos.cn \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).