linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Thompson <michael.craig.thompson@gmail.com>
To: Badari Pulavarty <pbadari@gmail.com>
Cc: "Charles P. Wright" <cwright@cs.sunysb.edu>,
	Michael Halcrow <mike@halcrow.us>,
	linux-fsdevel@vger.kernel.org
Subject: Re: eCryptfs: Request for review
Date: Fri, 21 Oct 2005 16:44:09 -0500	[thread overview]
Message-ID: <afcef88a0510211444u7dba6dd5h7c7358ed4ad8982b@mail.gmail.com> (raw)
In-Reply-To: <1129757915.8716.29.camel@localhost.localdomain>

On 10/19/05, Badari Pulavarty <pbadari@gmail.com> wrote:
> It is telling you that there is already IO in progress on that page.
> Either you ended up in  __block_write_full_page() twice or called
> __block_write_full_page() before finishing up end_page_writeback().

OK, I have narrowed it down to the following: we are in
ecryptfs_writepage, and do the following:
lower_page = grab_cache_page(lower_inode->i_mapping, 0);
where lower_page is the page in the lower filesysetm we want to write to.

We consistantly panic when, after we do the grab_cache_page(), we have
a locked page which is set for PageWriteback....
PageWriteback(lower_page) != 0.

What I would like to know is how I should proceed when I am in this
condition. I am not sure if it is acceptable to simply return from the
function, or if I need to set some flags, or wait on the lock to free
up. Unfortunately, I haven't been digging around the VFS long enough
to know what makes sense in this case.

_Any_ guidance would be extremely helpful.

Cheers,
Mike

  reply	other threads:[~2005-10-21 21:44 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-18 19:38 eCryptfs: Request for review Michael Halcrow
2005-10-18 19:59 ` Greg KH
2005-10-19 15:36 ` Charles P. Wright
2005-10-19 19:00   ` Michael Thompson
2005-10-19 19:38     ` Charles P. Wright
2005-10-19 19:55       ` Michael Thompson
2005-10-19 21:02         ` Erez Zadok
2005-10-19 21:38         ` Badari Pulavarty
2005-10-21 21:44           ` Michael Thompson [this message]
2005-10-21 21:56             ` Shaya Potter
2005-10-21 22:49             ` Badari Pulavarty
2005-10-24 18:19               ` Michael Thompson
2005-10-26 20:05                 ` Michael Thompson
2005-10-26 20:13                   ` Anton Altaparmakov
2005-10-27 13:13                     ` Charles P. Wright
2005-10-20 14:25         ` Charles P. Wright
2005-10-26 23:29   ` Michael Thompson
2005-10-27 13:12     ` Charles P. Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=afcef88a0510211444u7dba6dd5h7c7358ed4ad8982b@mail.gmail.com \
    --to=michael.craig.thompson@gmail.com \
    --cc=cwright@cs.sunysb.edu \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mike@halcrow.us \
    --cc=pbadari@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).