From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Thompson Subject: Re: eCryptfs: Request for review Date: Fri, 21 Oct 2005 16:44:09 -0500 Message-ID: References: <20051018193811.GA11545@halcrow.us> <1129736164.25733.19.camel@polarbear.fsl.cs.sunysb.edu> <1129750686.29319.7.camel@polarbear.fsl.cs.sunysb.edu> <1129757915.8716.29.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: "Charles P. Wright" , Michael Halcrow , linux-fsdevel@vger.kernel.org Return-path: Received: from xproxy.gmail.com ([66.249.82.192]:26500 "EHLO xproxy.gmail.com") by vger.kernel.org with ESMTP id S1751241AbVJUVoK convert rfc822-to-8bit (ORCPT ); Fri, 21 Oct 2005 17:44:10 -0400 Received: by xproxy.gmail.com with SMTP id i26so493777wxd for ; Fri, 21 Oct 2005 14:44:09 -0700 (PDT) To: Badari Pulavarty In-Reply-To: <1129757915.8716.29.camel@localhost.localdomain> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 10/19/05, Badari Pulavarty wrote: > It is telling you that there is already IO in progress on that page. > Either you ended up in __block_write_full_page() twice or called > __block_write_full_page() before finishing up end_page_writeback(). OK, I have narrowed it down to the following: we are in ecryptfs_writepage, and do the following: lower_page = grab_cache_page(lower_inode->i_mapping, 0); where lower_page is the page in the lower filesysetm we want to write to. We consistantly panic when, after we do the grab_cache_page(), we have a locked page which is set for PageWriteback.... PageWriteback(lower_page) != 0. What I would like to know is how I should proceed when I am in this condition. I am not sure if it is acceptable to simply return from the function, or if I need to set some flags, or wait on the lock to free up. Unfortunately, I haven't been digging around the VFS long enough to know what makes sense in this case. _Any_ guidance would be extremely helpful. Cheers, Mike