From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Thompson Subject: Re: [PATCH 4/12: eCryptfs] Main module functions Date: Thu, 3 Nov 2005 09:09:24 -0600 Message-ID: References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103034929.GD3005@sshock.rn.byu.edu> <20051103060236.GB5044@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: Phillip Hellewell , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from xproxy.gmail.com ([66.249.82.195]:7953 "EHLO xproxy.gmail.com") by vger.kernel.org with ESMTP id S1030290AbVKCPJZ convert rfc822-to-8bit (ORCPT ); Thu, 3 Nov 2005 10:09:25 -0500 Received: by xproxy.gmail.com with SMTP id s14so91514wxc for ; Thu, 03 Nov 2005 07:09:25 -0800 (PST) To: Greg KH In-Reply-To: <20051103060236.GB5044@kroah.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 11/3/05, Greg KH wrote: > On Wed, Nov 02, 2005 at 08:49:29PM -0700, Phillip Hellewell wrote: > > +#include > > +#include > > net/ after linux/ please. Why do you need sock.h anyway? We don't, thanks for pointing that out. It will be removed. > > +/** > > + * Module parameter that defines the ecryptfs_verbosity level. > > + */ > > +#define VERBOSE_DUMP 9 > > +#ifdef DEBUG > > +int ecryptfs_verbosity = VERBOSE_DUMP; > > +#else > > +int ecryptfs_verbosity = 1; > > +#endif > > +module_param(ecryptfs_verbosity, int, 1); > > I don't think you want a "1" here, do you? Hint, it's not doing what > you think it is doing... Would you care to explain, providing its short, what it does? I don't mind admitting I don't know everything, especially when it comes to kernel code. If I am to RTFM, please point me to the right M. :) > > +void __ecryptfs_kfree(void *ptr, const char *fun, int line) > > +{ > > + if (unlikely(ECRYPTFS_ENABLE_MEMORY_TRACING)) > > + ecryptfs_printk_release(ptr, fun, line); > > + kfree(ptr); > > +} > > + > > +void *__ecryptfs_kmalloc(size_t size, unsigned int flags, const char *fun, > > + int line) > > > > Don't have wrappers for all of the common kernel functions, just call > them directly. We do call them directly as long as DEBUG is not defined. This code exists for development purposes (or debug, if you will) so that we can track memory allocations and other various things in the logs. All wrappers for the common kernel functions are #defined in ecryptfs_kernel.h so via preprocessing, it all becomes pretty. Of course, these can be removed, assuming that this is not an acceptable approach. Mike