From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Thompson Subject: Re: [PATCH 4/12: eCryptfs] Main module functions Date: Thu, 3 Nov 2005 09:40:17 -0600 Message-ID: References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103034929.GD3005@sshock.rn.byu.edu> <20051103060236.GB5044@kroah.com> <20051103154726.GA7614@mipter.zuzino.mipt.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: Greg KH , Phillip Hellewell , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from xproxy.gmail.com ([66.249.82.194]:601 "EHLO xproxy.gmail.com") by vger.kernel.org with ESMTP id S1030349AbVKCPkS convert rfc822-to-8bit (ORCPT ); Thu, 3 Nov 2005 10:40:18 -0500 Received: by xproxy.gmail.com with SMTP id s14so99818wxc for ; Thu, 03 Nov 2005 07:40:17 -0800 (PST) To: Alexey Dobriyan In-Reply-To: <20051103154726.GA7614@mipter.zuzino.mipt.ru> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 11/3/05, Alexey Dobriyan wrote: > On Thu, Nov 03, 2005 at 09:09:24AM -0600, Michael Thompson wrote: > > On 11/3/05, Greg KH wrote: > > > > +/** > > > > + * Module parameter that defines the ecryptfs_verbosity level. > > > > + */ > > > > +#define VERBOSE_DUMP 9 > > > > +#ifdef DEBUG > > > > +int ecryptfs_verbosity = VERBOSE_DUMP; > > > > +#else > > > > +int ecryptfs_verbosity = 1; > > > > +#endif > > > > +module_param(ecryptfs_verbosity, int, 1); > > > > > > I don't think you want a "1" here, do you? Hint, it's not doing what > > > you think it is doing... > > Would you care to explain, providing its short, what it does? I don't > > mind admitting I don't know everything, especially when it comes to > > kernel code. If I am to RTFM, please point me to the right M. :) > > include/linux/moduleparam.h:#define module_param(name, type, perm) > ^^^^ Thanks, my ability to read has improved. This will now be used properly :)