From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Thompson Subject: Re: [PATCH 1/12: eCryptfs] Makefile and Kconfig Date: Fri, 4 Nov 2005 11:07:01 -0600 Message-ID: References: <20051103033220.GD2772@sshock.rn.byu.edu> <20051103034207.GA3005@sshock.rn.byu.edu> <20051103230551.GB30487@kroah.com> <20051104163555.GA13420@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: Phillip Hellewell , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: Received: from xproxy.gmail.com ([66.249.82.196]:52952 "EHLO xproxy.gmail.com") by vger.kernel.org with ESMTP id S1750735AbVKDRHC convert rfc822-to-8bit (ORCPT ); Fri, 4 Nov 2005 12:07:02 -0500 Received: by xproxy.gmail.com with SMTP id s14so427452wxc for ; Fri, 04 Nov 2005 09:07:01 -0800 (PST) To: Greg KH In-Reply-To: <20051104163555.GA13420@kroah.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 11/4/05, Greg KH wrote: > On Fri, Nov 04, 2005 at 10:09:43AM -0600, Michael Thompson wrote: > > On 11/3/05, Greg KH wrote: > > > On Thu, Nov 03, 2005 at 09:21:16AM -0600, Michael Thompson wrote: > > > > On 11/2/05, Phillip Hellewell wrote: > > > > > These patches modify fs/Makefile and fs/Kconfig to provide build > > > > > support for eCryptfs. > > > > > > > > > > Signed off by: Phillip Hellewell > > > > > Signed off by: Michael Halcrow > > > > > Signed off by: Michael Thompson > > > > > > > > That should read: > > > > Signed off by: Michael Thompson > > > > > > No, that's not how it is documented on how to do this. Please try > > > again. > > > > I've just rummaged around in linux/Documentation and I have not been > > able to find, either in a specific file, or by looking at "The Perfect > > Patch", or other related links, on how to fix an incorrect > > "Signed-off-by" line. > > You do not have the "-"s in the statements above, that is what I was > referring to. > > thanks, > > greg k-h > You can surely see how I was confused, seeing that you replied to my updated and flawed "Signed off by" amendment, stating it was incorrect, while the original posting contained exactly the same error. However, now that I know what you were talking about, all things become clear. I'll be sure not to make this mistake again, if just for confusion's sake. Mike -- Michael C. Thompson Software-Engineer, IBM LTC Security