From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Thompson Subject: Re: [PATCH 6/12: eCryptfs] Superblock operations Date: Mon, 21 Nov 2005 09:57:05 -0600 Message-ID: References: <20051119041130.GA15559@sshock.rn.byu.edu> <20051119041910.GF15747@sshock.rn.byu.edu> <84144f020511190250x2efdbfb4vf33245b3f7216fe5@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT Cc: Phillip Hellewell , akpm@osdl.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, yoder1@us.ibm.com Return-path: To: Pekka Enberg In-Reply-To: <84144f020511190250x2efdbfb4vf33245b3f7216fe5@mail.gmail.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 11/19/05, Pekka Enberg wrote: > On 11/19/05, Phillip Hellewell wrote: > > +/** > > + * This is called through iput_final(). > > + * This is function will replace generic_drop_inode. The end result of which > > + * is we are skipping the check in inode->i_nlink, which we do not use. > > + */ > > +static void ecryptfs_drop_inode(struct inode *inode) { > > + generic_delete_inode(inode); > > +} > > Please drop this useless wrapper and introduce it when it actually > does something. It does do something. By providing this function, we over-ride the default flow of execution. If we did not provide this function, the flow would be the following: iput_final -> generic_drop_inode -> generic_delete_inode (or generic_forget_inode). However, since we do not care about the i_nlink value, which generic_drop_inode checks in order to call generic_delete_inode, we simply circumvent the check by redirecting the flow thusly: iput_final -> ecryptfs_drop_inode -> generic_delete_inode I don't see a problem with doing that, but perhaps there is? Please elaborate if so. > > Pekka > - > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Michael C. Thompson Software-Engineer, IBM LTC Security