From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Thompson" Subject: Re: [PATCH 5/13: eCryptfs] Header declarations Date: Thu, 4 May 2006 10:08:03 -0500 Message-ID: References: <20060504031755.GA28257@hellewell.homeip.net> <20060504033750.GD28613@hellewell.homeip.net> <84144f020605040751t2d2dca5ai4044f28d7118ee96@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7BIT Cc: "Phillip Hellewell" , "Andrew Morton" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@ftp.linux.org.uk, mike@halcrow.us, mhalcrow@us.ibm.com, mcthomps@us.ibm.com, toml@us.ibm.com, yoder1@us.ibm.com, "James Morris" , "Stephen C. Tweedie" , "Erez Zadok" , "David Howells" Return-path: Received: from wx-out-0102.google.com ([66.249.82.203]:59356 "EHLO wx-out-0102.google.com") by vger.kernel.org with ESMTP id S1750727AbWEDPIE convert rfc822-to-8bit (ORCPT ); Thu, 4 May 2006 11:08:04 -0400 Received: by wx-out-0102.google.com with SMTP id t16so340525wxc for ; Thu, 04 May 2006 08:08:04 -0700 (PDT) To: "Pekka Enberg" In-Reply-To: <84144f020605040751t2d2dca5ai4044f28d7118ee96@mail.gmail.com> Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On 5/4/06, Pekka Enberg wrote: > On 5/4/06, Phillip Hellewell wrote: > > + > > +#define ecryptfs_printk(type, fmt, arg...) \ > > + __ecryptfs_printk(type "%s: " fmt, __FUNCTION__, ## arg); > > +void __ecryptfs_printk(const char *fmt, ...); > > Why not plain printk? Originally, ecryptfs_printk was using a verbosity level, which is why there was a custom call wrapping printk. This is no longer the case, and the eCryptfs developers are currently looking at this, and are planning to remove the bulk of printks. Thanks, Mike -- Michael C. Thompson Software-Engineer, IBM LTC Security