Re: [PATCH] use list_* functions better in dcache.c

[Paul Menage <pmenage@ensim.com>]

>@@ -382,42 +389,18 @@ void prune_dcache(int count)
> 
> void shrink_dcache_sb(struct super_block * sb)
> {
>-	struct list_head *tmp, *next;
>-	struct dentry *dentry;
>-
>-	/*
>-	 * Pass one ... move the dentries for the specified
>-	 * superblock to the most recent end of the unused list.
>-	 */
>-	spin_lock(&dcache_lock);

Oops - you're walking dentry_unused without holding dcache_lock ...

>-	next = dentry_unused.next;
>-	while (next != &dentry_unused) {
>-		tmp = next;
>-		next = tmp->next;
>-		dentry = list_entry(tmp, struct dentry, d_lru);
>-		if (dentry->d_sb != sb)
>-			continue;
>-		list_del(tmp);
>-		list_add(tmp, &dentry_unused);
>-	}
>-
>-	/*
>-	 * Pass two ... free the dentries for this superblock.
>-	 */
>-repeat:
>-	next = dentry_unused.next;
>-	while (next != &dentry_unused) {
>-		tmp = next;
>-		next = tmp->next;
>-		dentry = list_entry(tmp, struct dentry, d_lru);
>+	struct list_head *entry, *next;
>+	
>+	list_for_each_safe(entry, next, &dentry_unused) {
>+		struct dentry *dentry = list_entry(entry, struct dentry, d_lru);
> 		if (dentry->d_sb != sb)