From: Richard Cheng <icheng@nvidia.com>
To: Tomasz Wolski <tomasz.wolski@fujitsu.com>
Cc: smita.koralahallichannabasappa@amd.com,
alison.schofield@intel.com, dan.j.williams@intel.com,
linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
nvdimm@lists.linux.dev, ardb@kernel.org,
benjamin.cheatham@amd.com, dave.jiang@intel.com,
jonathan.cameron@huawei.com
Subject: Re: [PATCH] dax/bus: Upgrade resource conflict message to dev_err() in alloc_dax_region()
Date: Thu, 14 May 2026 18:13:04 +0800 [thread overview]
Message-ID: <agWfgLxDeu_duejj@MWDK4CY14F> (raw)
In-Reply-To: <20260514093208.13110-1-tomasz.wolski@fujitsu.com>
On Thu, May 14, 2026 at 11:32:08AM +0800, Tomasz Wolski wrote:
> The dax_region resource conflict in alloc_dax_region() indicates a
> serious configuration problem — two subsystems (e.g. dax_hmem and
> dax_cxl) are attempting to register overlapping address ranges. This is
> not a transient or debug-level condition; it represents a genuine
> resource conflict that an administrator needs to be aware of.
>
> Promote the log level from dev_dbg() to dev_err() so that the conflict
> is visible by default without requiring dynamic debug to be enabled.
>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Link: https://lore.kernel.org/linux-cxl/69c1a8d1c0fa9_7ee3100a1@dwillia2-mobl4.notmuch/
> Fixes: 34f80bb969cc ("dax: Track all dax_region allocations under a global resource tree")
> Signed-off-by: Tomasz Wolski <tomasz.wolski@fujitsu.com>
> ---
> drivers/dax/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index 68437c05e21d..cd963eeeef7b 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -672,7 +672,7 @@ struct dax_region *alloc_dax_region(struct device *parent, int region_id,
>
> rc = request_resource(&dax_regions, &dax_region->res);
> if (rc) {
> - dev_dbg(parent, "dax_region resource conflict for %pR\n",
> + dev_err(parent, "dax_region resource conflict for %pR\n",
> &dax_region->res);
> goto err_res;
> }
> --
> 2.47.3
>
>
Hi Tomasz,
Did you run into any kind of error or even machine crashing from this ?
btw, though I am not against the change, I don't think this is a fix, maybe you can consider to remove the Fixes tag.
Best regards,
Richard Cheng.
prev parent reply other threads:[~2026-05-14 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 9:32 [PATCH] dax/bus: Upgrade resource conflict message to dev_err() in alloc_dax_region() Tomasz Wolski
2026-05-14 10:13 ` Richard Cheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agWfgLxDeu_duejj@MWDK4CY14F \
--to=icheng@nvidia.com \
--cc=alison.schofield@intel.com \
--cc=ardb@kernel.org \
--cc=benjamin.cheatham@amd.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=smita.koralahallichannabasappa@amd.com \
--cc=tomasz.wolski@fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox