From: Christoph Hellwig <hch@infradead.org>
To: Yi Xie <xieyi@kylinos.cn>
Cc: linux-fsdevel@vger.kernel.org, Chuck Lever <cel@kernel.org>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: [PATCH] exportfs: fix error handling in expfs.c
Date: Mon, 18 May 2026 23:30:46 -0700 [thread overview]
Message-ID: <agwDlgy8EOC9sJEJ@infradead.org> (raw)
In-Reply-To: <20260519010140.37251-1-xieyi@kylinos.cn>
On Tue, May 19, 2026 at 09:01:40AM +0800, Yi Xie wrote:
> dentry_open() and fh_to_parent() were calling PTR_ERR() before
> checking IS_ERR().
Calling PTR_ERR before IS_ERR is perfectly fine as long as the result
in only used when IS_ERR is true.
> Drop the redundant sched.h include too, cred.h
> already pulls it in.
And this has nothing to do with the rest.
next prev parent reply other threads:[~2026-05-19 6:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 1:01 [PATCH] exportfs: fix error handling in expfs.c Yi Xie
2026-05-19 6:30 ` Christoph Hellwig [this message]
2026-07-10 7:51 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agwDlgy8EOC9sJEJ@infradead.org \
--to=hch@infradead.org \
--cc=cel@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xieyi@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox