From: "Oscar Salvador (SUSE)" <osalvador@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Dev Jain <dev.jain@arm.com>,
akpm@linux-foundation.org, liam@infradead.org, ljs@kernel.org,
jgg@ziepe.ca, leon@kernel.org, shuah@kernel.org,
vbabka@kernel.org, jannh@google.com, pfalcato@suse.de,
rppt@kernel.org, surenb@google.com, mhocko@suse.com,
balbirs@nvidia.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org, ryan.roberts@arm.com,
anshuman.khandual@arm.com, stable@vger.kernel.org
Subject: Re: [PATCH] fs/proc/task_mmu: do not warn on seeing non-migration pmd entry
Date: Tue, 2 Jun 2026 06:20:26 +0200 [thread overview]
Message-ID: <ah5aCjLl1dx546SQ@localhost.localdomain> (raw)
In-Reply-To: <a62302f8-24ea-4d21-963d-48bec766766b@kernel.org>
On Sun, May 31, 2026 at 09:11:53PM +0200, David Hildenbrand (Arm) wrote:
> The whole thp_migration_supported() guard is a bit shaky, right?
>
> I guess device-private entries currently imply thp_migration_supported(), but
> that thp_migration_supported() check is really questionable and should likely
> just go away (else if -> else).
>
> Staring at pte_to_pagemap_entry(), likely we'd also want
>
> if (softleaf_has_pfn(entry))
> page = softleaf_to_page(entry);
>
> to prepare for PMD swap entries.
Yes, that is what I was doing for non-present PMDs when implementing the
new API [1].
[1] https://lore.kernel.org/linux-mm/20260525165528.184397-5-osalvador@suse.de/
--
Oscar Salvador
SUSE Labs
next prev parent reply other threads:[~2026-06-02 4:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-29 11:17 [PATCH] fs/proc/task_mmu: do not warn on seeing non-migration pmd entry Dev Jain
2026-05-29 16:45 ` Lorenzo Stoakes
2026-05-29 23:36 ` Andrew Morton
2026-05-31 19:11 ` David Hildenbrand (Arm)
2026-06-01 4:56 ` Dev Jain
2026-06-01 5:48 ` David Hildenbrand (Arm)
2026-06-02 4:20 ` Oscar Salvador (SUSE) [this message]
2026-06-02 4:21 ` Oscar Salvador (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah5aCjLl1dx546SQ@localhost.localdomain \
--to=osalvador@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=balbirs@nvidia.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=jannh@google.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
--cc=pfalcato@suse.de \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shuah@kernel.org \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox