From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A324930CD95; Thu, 18 Jun 2026 09:36:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781775363; cv=none; b=PyyfcSaKk8uA0Ujy0wj1vbu2ITndZz1g50pt74zeH9vB/F8UnDoFOJhfLw9vUtmKn9oi8FDvkLA+AtmvhqY/X/AjTFpfbeFEnTifYzOFnUyBvRHaaA5uWiYMj1JuaIihub2POkO24rcP+YXIiJmJ2LRySxusA1yoca9Lycff0UA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781775363; c=relaxed/simple; bh=P9n7eGdqJOGmvD0c5Mp5cgGCsG75MKCfe6lEc0Wxq+k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XWPyy5O7ZkQh7bmg2Aa8SrYpE9s44jzvDDlFAJGymiU3PVgTVhyyW0X60hTlSIU5tr4hiC7KFcyBEjsUyp4qdUYqlpM7aJlIOGfxVffhLGn9c7WC2zLIgj/jviGVqJghRL5GFwRF/tgxVi+VIc43fMbiw687MXsexQyMRXk+x1k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=i88N8zVY; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="i88N8zVY" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=bryYsgJLmpz/0bnPfKrtP5aBJZ/WQo8rb2E54KYZps0=; b=i88N8zVYADwE59FedHNDy5uC0O 4cMq23kzqVs96Zct9+Yz2V3RRVifFyDy+kLQnz6bh8JxgpZ5bGL3qlsYtfet6Q3KN4koc+/tMHByd SGJMe+3IMxOoSYWcIV+28FNjafjwXe9hPAttBBeFg5YcE6k9+Szkcy0n9DpuHLt/w6KSSHL9mBxKn 3iV923d151DcM0+UrfmW55piDk7dAcrR5sr2/RRF8pW6PSrhR6K6K08RAY4kVx62Ho1sPmbS9bKqq 7pPTY9FIfn/xEmVGPKYLbLQIprtenaXYzkHzeCi/KL6o/35k9vJAHZYAW30csKOHZHGRGivGUqUAw VX5n3NJA==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wa9AG-00000000yiu-2lnE; Thu, 18 Jun 2026 09:36:00 +0000 Date: Thu, 18 Jun 2026 02:36:00 -0700 From: Christoph Hellwig To: "Pankaj Raghav (Samsung)" Cc: Christoph Hellwig , Pankaj Raghav , linux-xfs@vger.kernel.org, bfoster@redhat.com, lukas@herbolt.com, "Darrick J . Wong" , dgc@kernel.org, gost.dev@samsung.com, andres@anarazel.de, kundan.kumar@samsung.com, cem@kernel.org, Zhang Yi , linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH v6 3/3] xfs: add support for FALLOC_FL_WRITE_ZEROES Message-ID: References: <20260611114029.176200-4-p.raghav@samsung.com> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Thu, Jun 18, 2026 at 11:28:15AM +0200, Pankaj Raghav (Samsung) wrote: > > But I guess not unaligned FALLOC_FL_WRITE_ZEROES? > > -r readbdy: 4096 would make reads page aligned (default 1) > -t truncbdy: 4096 would make truncates page aligned (default 1) > -w writebdy: 4096 would make writes page aligned (default 1) > > FALLOC_FL_WRITE_ZEROES comes under truncate. So I would assume we also > do that. That is how I also found the issue with offset > EOF. I will > take a look or else, I will add a test case to test this condition! A targeted test using xfs_io that does FALLOC_FL_WRITE_ZEROES on an unaligned range and then checks that the data around it is preserved while the unaligned data in the range is zeroed would also be useful.