From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89EF23368A4 for ; Thu, 9 Jul 2026 06:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783577960; cv=none; b=oWZwcDBqvsuYliPVrxbSEHmLpo+Z6Yt4WY6bfCfGovc5gTdBMKuZeZHZ9ZHCWQDqhJko/MXhpbWAqjKNlc8dHus6+2kOK1SYwz9kJ6A+lRnlH+hpuzPOyug8+92cU7BzvC3jPKbJCji/etIKM+p7Btl3quWKo6c91VnpEm0a/74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783577960; c=relaxed/simple; bh=ZGwIsrqjg3x5F2mnz6g66MzYCqQwBZkm250mDjNhtGo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WQgM3/maGHIyJMvvWs4SA6odnWEOgY8Ee3vKKrmQ6WeHrAE2+v/lwpAJyfongWCK4SrOnexbADP9C3GYGGGpsIQqr1MWjZbxIhjjANU4MQnugUFuissUtNCW1CytGkJoS3QVRj++QOHxO2opvzVhZPqk6xyJIsV8lyUnVUC64a0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=AXMn+ukf; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="AXMn+ukf" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2cab97c86bdso48635ad.1 for ; Wed, 08 Jul 2026 23:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1783577959; x=1784182759; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=sVwokARvELpibyxJ1Yufay2/9dNo2BXnunlPaasxpXQ=; b=AXMn+ukffNCxA4rzCPiRdVjePE1UP0iq+wvZ0tcM+0konhgXOIuZRvLmCjtUr/ViTN Z0yVhZDgwQzHmuGzYhbyduNckl8ZS48MF40zQ2Utb9/xlEJhvEBHz8ni3OQAivuYO6xL BPOHqB60K2CZ41hE0sB+r0hBTPiefaCpkPDFNn+NQQrS39fYmnMrzHGjff8pZjxzwtKr NgXP19a82/xxTkcO8My8V1PossmrgC0BW9i2gWTMm8iu34WGDuTOvONUI6OGc03VYDIr rKnrL6CPdcj5+klPy/eD+2Dr1hnEXS1P/DrYRg10mahOODF+Fur1p2rdtkrSDyRfE+sp SZ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783577959; x=1784182759; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sVwokARvELpibyxJ1Yufay2/9dNo2BXnunlPaasxpXQ=; b=VW2G8ppyEwyYE0iGth15/6Ya9+xO3nAVULNFlPS9/IRUuJNzdl+TcFF3OkKvNWA4ur u2jq5y5BAW7BR8YRt5Hr4nbZK5pkoyt+kKZytWwqsh/5JyMjyAaPcYzGvEYMpscaM+Vv W8Ami6EZK4JA5kLlOWfLnlUJvUeDYcyr6jXysI5vyQ6vkM0OPfxf2PG/JpYMFWRF2kI6 h+Mjiux/4RmAZSmbpmA3Xyz/LwxqaUe2BNVltWqf8PH+R11sVakMHSDuCYLT0UBcrnzB D4x4mXVh8UgHM7VY8+gLQ9Wx0a6QQn71NwO3jvdvr9/VxcDFN/3UQTPsSpaIXf2v5ioL 8YyA== X-Forwarded-Encrypted: i=1; AHgh+RrF/aPKGfdBzImoyBulareVaItGBYlMIouEgaqA/MMiJZT/OTxzikPRMCYyl0idbiy1IANORqCPInlEYlQs@vger.kernel.org X-Gm-Message-State: AOJu0Yw4zO28Fu30nXJeC9s6pKGt1EPG1hlVXiJb8BtHmGhUUZrZ607g 6iRxtFYBKVA795cX1ccz0k0+rh7yLGK2Su5MOq3OkihUmVHMQ0V5mvU5OawilKHbOSeIggYOWzq ezw+f6g== X-Gm-Gg: AfdE7clNwvpcMJl3YVVwMISs8cf5kr99swYCqUnfc97/ywVtu0/TJBMtr4HJf/+QhtH v39v+gtLo0hODRpeDGovLunmPTGOgjil09VIRfC+bpMAB77fEZ5cZTxo/CLoSlzM9XnWrGuRWFh GL9+TbxWPGng/oZIW4c7Br64zT/XFRGXbX+01nRemZ+v3Stzhua6QWMNle69nuJKvV4YfuFOuaH tm6p9w4O8c/hjtjcTY5qfGIniP9/T5/bUQXkNDoCxxrMqTh1Postl8/qX/EyozZYkgQvxLEROYM 4qznNsWoreimIHSC5wGtowNUfM4Eud+5CFQZz1sSeufq3YxbZ46dzs497YgHdzPAGIl8bNBmals sYvq5DGnXgMxCnm+9nebLwhvJjb4vPRG5LeMXTzoeMX6RM8F7xmVCfokXzc/9OOX9z/uzjN6LmX 7ske26dfA+1ToeMwcezKk62JYUYL1YjtkZUVINUpDFVJsP5ck= X-Received: by 2002:a17:903:3d10:b0:2ca:ed25:9c2f with SMTP id d9443c01a7336-2cd57365bfbmr1755705ad.16.1783577958430; Wed, 08 Jul 2026 23:19:18 -0700 (PDT) Received: from google.com (10.129.124.34.bc.googleusercontent.com. [34.124.129.10]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38a5574ca88sm593811a91.7.2026.07.08.23.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 23:19:17 -0700 (PDT) Date: Thu, 9 Jul 2026 06:19:12 +0000 From: Pranjal Shrivastava To: Christoph Hellwig Cc: Matthew Wilcox , Trond Myklebust , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Anna Schumaker , Shivaji Kant , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 6/7] nfs: Optimize direct I/O to use folios for requests Message-ID: References: <7ee3bcfdd6126c93cbb1c219bf601182b95c10d9.camel@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jul 08, 2026 at 11:47:27AM +0000, Pranjal Shrivastava wrote: > On Wed, Jul 08, 2026 at 12:48:56AM -0700, Christoph Hellwig wrote: > > On Tue, Jul 07, 2026 at 12:08:27PM +0000, Pranjal Shrivastava wrote: > > > Ack. I see! Thanks! > > > > > > Regarding the page_folio impasse, how do you suggest we proceed? Should > > > I expose and use get_contig_folio_len() from bvec? Or should I move the > > > NFS helper into the iov_iter lib? (or both). > > > > Sounds like the best way forward for now. > > Ack. I'll reuse get_contig_folio len and move the nfs extractor to > iov_iter for v3. > On a second thought, I guess I'd try taking a stab at writing iov_iter_extract_folios and handle the vmalloc / slab cases for kvecs. I believe that would be the right way to go, unless I'm missing something obvious? Can I take a stab at it in the next version? Thanks, Praan