From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f49.google.com (mail-qv1-f49.google.com [209.85.219.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FBFF3F0765 for ; Thu, 9 Jul 2026 15:57:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612639; cv=none; b=IijnYjitJpqzv1IqpCgSuI/Wl3ajyOtlE1MSxqMjQuB59i9ui5wd+JLMyvPJL5i29XDNNS59RSXVJj7K9OweX4mVHQdQ2Xm/JC4Tegsk3sbauORA12zN38MI51g+DXD7BcM+iDD0jkg88VrLutN5QweWfltU9qOzz/5WTL0YFfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783612639; c=relaxed/simple; bh=zOqJj5IGDkUHkuE0A0VjkQNttgCPQIdWlZYAcSbicnE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DqywsLQGB01ctpOSHBmkg+nzvXhtp39CNwDI8g5CyOGNrayYh2i31zBuTYujdNe9AngF+FtCYuktZaV2/yX40PDCLZSuEa9rEkp9ZmfVvxaStK+bo11q46Exb7gFl1AzbS0rD+RDe/7j3MM1/SdJ4q5KYMiMzvhMtHcQJuMlKrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=JaiPRMxW; arc=none smtp.client-ip=209.85.219.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="JaiPRMxW" Received: by mail-qv1-f49.google.com with SMTP id 6a1803df08f44-8f18d92172aso760216d6.2 for ; Thu, 09 Jul 2026 08:57:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783612635; x=1784217435; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=T5BtG8ZZnILhla7gs7f63UlRSUpFIkMkPS04TXxov0k=; b=JaiPRMxWcQcvwomxKrNgkR+V+GW/eBHpnGZNau6MH5y450xJl98VMTJJHAF9jRsuXC Xt7mR7KeawTZPVnKboCCSGbsxow5a2PgFeiSY8/XWddVDWFrEWmFXtO5W/Dl0nrr5olU FHib07hylrfhwz/tO61AsseU9KRqyHxGgKPeBcjHWB/NVjmWrN59d0H3M1NQXERgA5Mw SBvOCnVFfjsbezQ1DAbcIXDOTZgXYgBqCjS4/QI1RF06UoQPY6hmEkM7zoDzdAY2dn+j Mu9hGDFmirDa4O7n5AJQfExMa5HZRVOJt/+stBKx4vf5W+gioGtJL2bg1Fid5qnDWQi0 ldYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783612635; x=1784217435; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=T5BtG8ZZnILhla7gs7f63UlRSUpFIkMkPS04TXxov0k=; b=T34JZZ9PeD12dMfyYWAFd7HlSlsQ3lyR37Q5ArtmQBI3ngp0QDzy9nNdDbi/VeRwwv 4PQXdpaWDxP49a74fysL6KgrA/oZ7J6IAE558Y3gyB/NYW3lvEzoXf0Mt9umXZgM7/bM 5BrgKfOZPV7yW5kVwm+Iv9sERuoGvXjoa6iT328hJfxTkxfSRlRiOo83h8BlLGJOR4GC XaAraXulxOLaBTMzetPXjC9y9FYPphEGGpxA6iMchL25pe8Xg/P/IsDc4dbk4JkRaeqq lPlte7pP9aHgnKtWy1aE7VwbZ7hED0uJbc07uR58oZ12Jz3J5N+WYM9/XQkuCNhobX6x +nNg== X-Forwarded-Encrypted: i=1; AHgh+Rq1+DwBJkxGuf1cR2FlMx86F7ED8phq+AfppJjOoXYt8e1+tUQBWpDPkkUrZSBQNfqdu1dpykhuzJ+5iyA5@vger.kernel.org X-Gm-Message-State: AOJu0YxxFdax9kboxz4HL3350r08XMiRSL84Z5K7dme2TKdKcSjmGxGm Si/oOx8+WO7SEzUO0HjAd+3p9nwRZRrYOTiWubRZeZmjMXPuFBhuL9bb7wtm+h7cvh0= X-Gm-Gg: AfdE7cmbkGWHM0TnhtuFLzcsEDqWlui7x2mIy/vNLKWpQl0S7vH1aBTQa1tIEs8zgT3 F8zalSGI7fYDClaCcx+Y82eWxDtyPvItp85OX5WgidwRlORzomgQjryUM++AonfozK5qq5YKFtb 3CduvArjhtbfigbIySRodmRuzvVUiCOvfBLZDMS3AgZVrK8SEK/c5q48RHgEBn1KwWqfGojH0ns 3Njfnq2y/aGfiugURirsEseGM7CDUIrKvpL56phUC4+73KWmDw/Y/ovtTn1UkQkuP+JYWd8DtO5 GR+OxK5gb0IPGBxyIvgLdD8wjhjl5OfFTNRwatBAz7CTzG6lRnxLz8YoJyu5y5Vx+VkOMlz9N6y 3mDdWMjxxH/1JNalhiGwcKSMCJFLBrb7LejFJOY8ROX1AUN+gNgQMx/LM2hc5ymtsIExFJlng+D 0PSmP0KwsSm0z+tOY1aVyBL48Nbn0eNpUkA7vOSkwsLcGdpNVO/JOBNTCjFbPDPAQ6K8D9xlxIn 8P7nYE= X-Received: by 2002:a05:6214:2aa6:b0:8f3:e0ce:6119 with SMTP id 6a1803df08f44-8fec0ead52amr91789316d6.21.1783612635560; Thu, 09 Jul 2026 08:57:15 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd86d43e2sm20317526d6.43.2026.07.09.08.57.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 08:57:15 -0700 (PDT) Date: Thu, 9 Jul 2026 11:57:09 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 19/30] mm: use linear_page_[index, delta]() consistently Message-ID: References: Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jul 09, 2026 at 11:55:54AM -0400, Gregory Price wrote: > > @@ -2462,7 +2463,7 @@ static int comedi_vm_access(struct vm_area_struct *vma, unsigned long addr, > > { > > struct comedi_buf_map *bm = vma->vm_private_data; > > unsigned long offset = > > - addr - vma->vm_start + (vma->vm_pgoff << PAGE_SHIFT); > > + addr - vma->vm_start + (vma_start_pgoff(vma) << PAGE_SHIFT); > > > > Obviously correct, but was this intended for a different patch? > > ~Gregory bleh already caught, sorry for the noise :]