From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 22BB52857FA for ; Fri, 10 Jul 2026 19:38:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783712329; cv=none; b=bUXCzdj2WlXugKMAeKJOUNKu8DM2lR48+wxD9O0lFGFNMo6nEe4NvcJIXxFmposiUjSdIiYSoauChvDEjHz7fgfKYxBfOT/fYW9B9e7jZK7SkrYe0pJ3lagGnbB+kiuw/J91wURSfJVEv0lUsv3a2w4Cz3JaF8aC1OhDirbVlM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783712329; c=relaxed/simple; bh=93/k6XquwkESRTY8Qvhh+3gNAdxoxyU3Cel9zV++PQc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tmjSUcV5PUCkMmGlDZI6fBkX1avCwbsD1lwAcOYkkJI/mSX7FWH88SC+mfVz7DhDjVftxsX/T2LATj2WJADS3+v8Vay+Gzsh3vE1CHAlUAOmSAPsTdbYEXXydBzD+XkypJYLhbp8Qj58b//U03XaXS69N2OUbP5oN0XWitbzgTs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=al6+H7t/; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="al6+H7t/" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8efcef23d21so10478306d6.2 for ; Fri, 10 Jul 2026 12:38:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1783712326; x=1784317126; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=68XwZpqFqsaLFsxYJLdxs3+k1PzHke/kGWmUPy80R6g=; b=al6+H7t/CFEDBMibUEjHT8p3L+i06ZY4PpzYTOaT3H9bmkq7jfHUo3l3PnBaKTidw/ 41fRtV6c73J9a6EkTdDqcnOfEQorPxnzGS6/9Y1+OFWPQmkfiiFWskhjbk63ZmZ3KBjU awR3OazwaD2FGph0VjOMptZBbgJmJ/NdJO8j3UEICVdx0ecAKcSbw8AKV8ez4kCwg/9I em2ziGKWGdmKma0Hj2zA1W3dulz6Dhh897KVlLWCe9NDLfqgWJVDgLDK2QLxPVk3N9dY UC+qzerd8Z7PEVFHnn9/eHTXU2Xf/U0yPJeaHZGLsSkEktOdZfibqKLagpFacohoUMx8 LmLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783712326; x=1784317126; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=68XwZpqFqsaLFsxYJLdxs3+k1PzHke/kGWmUPy80R6g=; b=Pl8efYQdkueGi09UavGEno/T3m4HjsquTCh997f1NAlUHYX73vzx4BJn7hQogNObjl LVixcOyZyWJ6rXxgO/1In0xmPEEuOo+5DgaOJKbN4S+3ad+CsCFbOP6q53ZEV/7S2wr9 Z7m/nlKoeIWjmnSn3L0d5DrgSdLsmHB53zj17djG4vrcMZSNpjxv3Vl9gYAng2wzmuSI hL4q6Oix4R7zC9PL4OQdWvTU6/Rb+S+l3odKyb0DvtLGwiz9jKPv78jrOowY5nAX1zTd Oe33DBdtrqSr9gE57K9Ppz7bdCP3dX56kof1vbKPMZqVcioL629tQ6OnMvIbe1fsA5ug iQKA== X-Forwarded-Encrypted: i=1; AHgh+Rr3tlNV+S54595rtkVe+5Sv6XJxW4FcxZTK1Pmq1JV742VzKH+2ley9CG9zuGtYtiMlvHCWE2Z3ZQ7chbYm@vger.kernel.org X-Gm-Message-State: AOJu0YzxKLdHk1C7W9lP5knkfKw2Bl0gY822gcxbgQJKcfNxgcPvLwrD lsrnMfFEwZb/kZf1J9UhavLUwSZEFbAZhGords2lV1Mo3lt+ScVp3k4gT2hFvEjdDhc= X-Gm-Gg: AfdE7ckJdr/kA5fNn65aAw6eyiTvkgu285BqDIPtQNzjXmntZCKL01UwxOqIURnM6VX Gg0Zy64PQeyAjcyfcYZQ+aeBIhYwQHi5BfI0oYh7BA94IjkMiV9J4RnCLURix4E4/EVvo+zhtJv +yr1S8e1SLXWsHoe2+obS42t1ZiQ+BdhQ2UwwhXd1Mcxj8VrGC0XCoNU3FRUXLP6YO5VHBNmpOj hB03/d8ymvo496g4VQz8J4FRe2MCiIiUlRVq35RcsvYDfKt+fymzgsDw2F9MCo+6STZBRGTwT+C qnVAqcJ53XXWHnQxNaGIc3tjMayWq0+/AbBd8L7v6FStjltOuQyvqXpG+PFrBatpES5WMufUusx 7JPBfxj/VJFmJMt1axtIpVAljit+8nU61ZE/5DJnhclCPO3GWKtp/10QUtxm3QltUr+xL9Wmda3 pgOQJ8TNhrpnNeV6GMWQ/Vbt2YzXhX+DHIBKAoYFEhEttiF5EQ9VQQMS2j4aScmFY0K4K+ X-Received: by 2002:a05:6214:4b08:b0:8dd:fde8:68c7 with SMTP id 6a1803df08f44-90402c685c0mr4983166d6.30.1783712326120; Fri, 10 Jul 2026 12:38:46 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd87c9500sm48486486d6.46.2026.07.10.12.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 12:38:45 -0700 (PDT) Date: Fri, 10 Jul 2026 15:38:40 -0400 From: Gregory Price To: Lorenzo Stoakes Cc: Andrew Morton , Russell King , Dinh Nguyen , Simon Schuster , "James E . J . Bottomley" , Helge Deller , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Ian Abbott , H Hartley Sweeten , Lucas Stach , David Airlie , Simona Vetter , Patrik Jakobsson , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Clark , Dmitry Baryshkov , Tomi Valkeinen , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Christian Koenig , Huang Rui , Ankit Agrawal , Alex Williamson , Alexander Viro , Christian Brauner , Dan Williams , Muchun Song , Oscar Salvador , David Hildenbrand , Suren Baghdasaryan , "Liam R . Howlett" , Matthew Wilcox , Marek Szyprowski , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Masami Hiramatsu , Oleg Nesterov , Steven Rostedt , SeongJae Park , Miaohe Lin , Hugh Dickins , Mike Rapoport , Kees Cook , Paolo Bonzini , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-parisc@vger.kernel.org, linux-sgx@vger.kernel.org, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, linux-tegra@vger.kernel.org, kvm@vger.kernel.org, linux-fsdevel@vger.kernel.org, nvdimm@lists.linux.dev, linux-mm@kvack.org, iommu@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kasan-dev@googlegroups.com, damon@lists.linux.dev, Pedro Falcato , Rik van Riel , Harry Yoo , Jann Horn Subject: Re: [PATCH 28/30] mm/vma: use guard clauses in can_vma_merge_[before, after]() Message-ID: References: <213918ef85ed427d29d0635db6b07b15280d3bb0.1782735110.git.ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <213918ef85ed427d29d0635db6b07b15280d3bb0.1782735110.git.ljs@kernel.org> On Mon, Jun 29, 2026 at 01:23:39PM +0100, Lorenzo Stoakes wrote: > Rather than combining a bunch of conditionals in a single expression, > simplify by inverting the mergeability requirements into guard clauses. > > that is - instead of checking what must be true for the conditions to be > met, instead check the inverse of the requirements and return false if any > are true, defaulting to true. > > No functional change intended. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Gregory Price