From: Nicolas Pitre <nicolas.pitre@linaro.org>
To: Joe Perches <joe@perches.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Greg Ungerer <gerg@linux-m68k.org>
Subject: Re: [PATCH v3 02/12] binfmt_flat: convert printk invocations to their modern form
Date: Wed, 20 Jul 2016 01:05:00 -0400 (EDT) [thread overview]
Message-ID: <alpine.DEB.2.20.1607200038420.27128@Yrabib> (raw)
In-Reply-To: <1468989000.1900.94.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 2263 bytes --]
On Tue, 19 Jul 2016, Joe Perches wrote:
> On Wed, 2016-07-20 at 00:20 -0400, Nicolas Pitre wrote:
> > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c
> []
> > @@ -15,6 +15,8 @@
> > � * JAN/99 -- coded full program relocation (gerg@snapgear.com)
> > � */
> > �
> > +#define pr_fmt(fmt) "BINFMT_FLAT: : " fmt
>
> Why the double colon?
Go figure.
> Much more common would be
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
Sure. I used the all-caps version as that's what most former printk's
used. But if you say KBUILD_MODNAME is more common then I have no issue
with that.
>
> > @@ -106,8 +98,8 @@ static struct linux_binfmt flat_format = {
> > �
> > �static int flat_core_dump(struct coredump_params *cprm)
> > �{
> > - printk("Process %s:%d received signr %d and should have core dumped\n",
> > - current->comm, current->pid, cprm->siginfo->si_signo);
> > + pr_warning("Process %s:%d received signr %d and should have core dumped\n",
> > + ���current->comm, current->pid, cprm->siginfo->si_signo);
>
> Prefer pr_warn
OK.
Updated in my repo and pushed out.
> > � return(1);
> > �}
> > �
> > @@ -190,17 +182,17 @@ static int decompress_exec(
> > � loff_t fpos;
> > � int ret, retval;
> > �
> > - DBG_FLT("decompress_exec(offset=%lx,buf=%p,len=%lx)\n",offset, dst, len);
> > + pr_debug("decompress_exec(offset=%lx,buf=%p,len=%lx)\n",offset, dst, len);
>
> Generally unnecessary as the function tracer works well
Not necessarily on uClinux where you might not aford it.
And this patch is about converting existing printk()'s so if some of
them should be removed then it would be best to do that separately.
> > � memset(&strm, 0, sizeof(strm));
> > � strm.workspace = kmalloc(zlib_inflate_workspacesize(), GFP_KERNEL);
> > � if (strm.workspace == NULL) {
> > - DBG_FLT("binfmt_flat: no memory for decompress workspace\n");
> > + pr_debug("no memory for decompress workspace\n");
> > � return -ENOMEM;
> > � }
> > � buf = kmalloc(LBUFSIZE, GFP_KERNEL);
> > � if (buf == NULL) {
> > - DBG_FLT("binfmt_flat: no memory for read buffer\n");
> > + pr_debug("no memory for read buffer\n");
>
> Unnecessary OOM messages as allocs do a stack dump
Again this should probably be done separately.
Nicolas
next prev parent reply other threads:[~2016-07-20 5:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 4:20 [PATCH v3 00/12] allow BFLT executables on systems with a MMU Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 01/12] binfmt_flat: assorted cleanups Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 02/12] binfmt_flat: convert printk invocations to their modern form Nicolas Pitre
2016-07-20 4:30 ` Joe Perches
2016-07-20 5:05 ` Nicolas Pitre [this message]
2016-07-20 4:20 ` [PATCH v3 03/12] binfmt_flat: prevent kernel dammage from corrupted executable headers Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 04/12] elf_fdpic_transfer_args_to_stack(): make it generic Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 05/12] binfmt_flat: use generic transfer_args_to_stack() Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 06/12] binfmt_flat: clean up create_flat_tables() and stack accesses Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 07/12] binfmt_flat: use proper user space accessors with relocs processing code Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 08/12] binfmt_flat: use proper user space accessors with old relocs code Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 09/12] binfmt_flat: use clear_user() rather than memset() to clear .bss Nicolas Pitre
2016-07-20 7:15 ` Greg Ungerer
2016-07-20 4:20 ` [PATCH v3 10/12] binfmt_flat: update libraries' data segment pointer with userspace accessors Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 11/12] binfmt_flat: add MMU-specific support Nicolas Pitre
2016-07-20 4:20 ` [PATCH v3 12/12] binfmt_flat: allow compressed flat binary format to work on MMU systems Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1607200038420.27128@Yrabib \
--to=nicolas.pitre@linaro.org \
--cc=dhowells@redhat.com \
--cc=gerg@linux-m68k.org \
--cc=joe@perches.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).