From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28928C169C4 for ; Tue, 29 Jan 2019 13:30:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0D8921473 for ; Tue, 29 Jan 2019 13:30:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725911AbfA2NaC (ORCPT ); Tue, 29 Jan 2019 08:30:02 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:47726 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726298AbfA2NaC (ORCPT ); Tue, 29 Jan 2019 08:30:02 -0500 X-IronPort-AV: E=Sophos;i="5.56,537,1539640800"; d="scan'208";a="293665196" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2019 14:29:59 +0100 Date: Tue, 29 Jan 2019 14:29:55 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: David Howells cc: linux-fsdevel@vger.kernel.org, Al Viro , kbuild-all@01.org Subject: [vfs:R46 74/77] fs/nfs/fs_context.c:1321:13-16: ERROR: reference preceded by free on line 1319 (fwd) Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Lines 1318 and 1319 need to be inverted. julia ---------- Forwarded message ---------- Date: Tue, 29 Jan 2019 20:40:00 +0800 From: kbuild test robot To: kbuild@01.org Cc: Julia Lawall Subject: [vfs:R46 74/77] fs/nfs/fs_context.c:1321:13-16: ERROR: reference preceded by free on line 1319 CC: kbuild-all@01.org CC: linux-fsdevel@vger.kernel.org TO: David Howells CC: Al Viro tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git R46 head: d49480196030012187093eda4b1a21012ede1b38 commit: 858e1ab929c3e46027ba791293a95559562cdbc3 [74/77] NFS: Add fs_context support. :::::: branch date: 12 days ago :::::: commit date: 12 days ago >> fs/nfs/fs_context.c:1321:13-16: ERROR: reference preceded by free on line 1319 # https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/commit/?id=858e1ab929c3e46027ba791293a95559562cdbc3 git remote add vfs https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git git remote update vfs git checkout 858e1ab929c3e46027ba791293a95559562cdbc3 vim +1321 fs/nfs/fs_context.c 858e1ab9 David Howells 2018-11-15 1301 858e1ab9 David Howells 2018-11-15 1302 /* 858e1ab9 David Howells 2018-11-15 1303 * Handle duplication of a configuration. The caller copied *src into *sc, but 858e1ab9 David Howells 2018-11-15 1304 * it can't deal with resource pointers in the filesystem context, so we have 858e1ab9 David Howells 2018-11-15 1305 * to do that. We need to clear pointers, copy data or get extra refs as 858e1ab9 David Howells 2018-11-15 1306 * appropriate. 858e1ab9 David Howells 2018-11-15 1307 */ 858e1ab9 David Howells 2018-11-15 1308 static int nfs_fs_context_dup(struct fs_context *fc, struct fs_context *src_fc) 858e1ab9 David Howells 2018-11-15 1309 { 858e1ab9 David Howells 2018-11-15 1310 struct nfs_fs_context *src = nfs_fc2context(src_fc), *ctx; 858e1ab9 David Howells 2018-11-15 1311 858e1ab9 David Howells 2018-11-15 1312 ctx = kmemdup(src, sizeof(struct nfs_fs_context), GFP_KERNEL); 858e1ab9 David Howells 2018-11-15 1313 if (!ctx) 858e1ab9 David Howells 2018-11-15 1314 return -ENOMEM; 858e1ab9 David Howells 2018-11-15 1315 858e1ab9 David Howells 2018-11-15 1316 ctx->mntfh = nfs_alloc_fhandle(); 858e1ab9 David Howells 2018-11-15 1317 if (!ctx->mntfh) { 858e1ab9 David Howells 2018-11-15 1318 return -ENOMEM; 858e1ab9 David Howells 2018-11-15 @1319 kfree(ctx); 858e1ab9 David Howells 2018-11-15 1320 } 858e1ab9 David Howells 2018-11-15 @1321 nfs_copy_fh(ctx->mntfh, src->mntfh); 858e1ab9 David Howells 2018-11-15 1322 858e1ab9 David Howells 2018-11-15 1323 __module_get(ctx->nfs_mod->owner); 858e1ab9 David Howells 2018-11-15 1324 ctx->client_address = NULL; 858e1ab9 David Howells 2018-11-15 1325 ctx->mount_server.hostname = NULL; 858e1ab9 David Howells 2018-11-15 1326 ctx->nfs_server.export_path = NULL; 858e1ab9 David Howells 2018-11-15 1327 ctx->nfs_server.hostname = NULL; 858e1ab9 David Howells 2018-11-15 1328 ctx->fscache_uniq = NULL; 858e1ab9 David Howells 2018-11-15 1329 fc->fs_private = ctx; 858e1ab9 David Howells 2018-11-15 1330 return 0; 5f07893d David Howells 2018-11-15 1331 } 858e1ab9 David Howells 2018-11-15 1332 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation