From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode() Date: Mon, 1 Oct 2007 10:44:59 -0700 (PDT) Message-ID: References: <20071001130921.29339.72876.stgit@warthog.procyon.org.uk> <20071001130958.29339.31669.stgit@warthog.procyon.org.uk> <20071001173930.GA7718@mami.zabbo.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=us-ascii Cc: David Howells , hch@infradead.org, viro@ftp.linux.org.uk, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org To: Zach Brown Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:44627 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751661AbXJARpf (ORCPT ); Mon, 1 Oct 2007 13:45:35 -0400 In-Reply-To: <20071001173930.GA7718@mami.zabbo.net> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, 1 Oct 2007, Zach Brown wrote: > > If you're soliciting opinions, I think I tend to prefer the feel of the > code paths after the changes. I don't know the benefits of the change > are worth the risk in unmaintained file systems, though. > > > + return ERR_PTR(PTR_ERR(inode)); > > This caught my eye. Surely we can do better :). It seems to happen a > few times in the patches, the instance in this patch was the first that > I noticed. Yeah. The above obviously *should* be the same as return inode; apart from a few casts. But if the casts matter, there's something else wrong. Linus