From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [PATCH 0/2] cramfs: Add mount option "swapendian" Date: Thu, 15 Nov 2007 12:45:20 -0800 (PST) Message-ID: References: <200711152129.25686.lists-receive@programmierforen.de> <200711152135.16932.lists-receive@programmierforen.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Andrew Morton To: Andi Drebes Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:38470 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761056AbXKOUpe (ORCPT ); Thu, 15 Nov 2007 15:45:34 -0500 In-Reply-To: <200711152135.16932.lists-receive@programmierforen.de> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, 15 Nov 2007, Andi Drebes wrote: > > This patch introduces the mount option "swapendian" for cramfs. > When this option is set, cramfs is able to mount an image that > was created on a machine whose endianness differs from the mounting > machine's one. Please don't do it this way. It would be *much* better to just standardize on one endianness, and be done with it. That way there are no config options, no confusion, and the code is smaller, simpler, and faster. Because nn unconditional byte swap is generally faster than a conditional non-byte-swap! So can you please just make it little-endian? There can't be that many big-endian machines that really care about old cramfs images.. Linus