From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [patch v3] splice: fix race with page invalidation Date: Wed, 30 Jul 2008 10:00:28 -0700 (PDT) Message-ID: References: Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: jens.axboe@oracle.com, akpm@linux-foundation.org, nickpiggin@yahoo.com.au, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org To: Miklos Szeredi Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:38500 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbYG3RDx (ORCPT ); Wed, 30 Jul 2008 13:03:53 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 30 Jul 2008, Miklos Szeredi wrote: > > There are no real disadvantages: splice() from a file was originally meant to > be asynchronous, but in reality it only did that for non-readahead pages, > which happen rarely. I still don't like this. I still don't see the point, and I still think there is something fundamentally wrong elsewhere. I also object to just dismissing the async nature as unimportant. Fix it instead. Make it use generic_file_readahead() or something. This is fixing things in all the wrong places, imnsho. Linus