From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Torvalds Subject: Re: [patch v3] splice: fix race with page invalidation Date: Wed, 30 Jul 2008 14:56:55 -0700 (PDT) Message-ID: References: <20080730175406.GN20055@kernel.dk> <20080730194516.GO20055@kernel.dk> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: jens.axboe@oracle.com, akpm@linux-foundation.org, nickpiggin@yahoo.com.au, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org To: Miklos Szeredi Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:56970 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753698AbYG3WAT (ORCPT ); Wed, 30 Jul 2008 18:00:19 -0400 In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 30 Jul 2008, Miklos Szeredi wrote: > > You are being unfair: after having talked it over with Nick I > resubmitted this patch (not the same), which was added to -mm and > nobody complained then. Then it got thrown out of -mm during the merge > window because of a conflict, and then now I got around to > resubmitting it again. Ok, fair enough. I don't follow -mm myself (since as far as I'm concerned, a lot of the point of -mm is that Andrew takes a lot of load off me). So yes, it was unfair and yes, I'd never have reacted to it in -mm. But I'd really like to get that PG_uptodate bit just fixed - both wrt writeout errors and wrt truncate/holepunch. We had some similar issues wrt ext3 (?) inode buffers, where removing the uptodate bit actually ended up being a mistake. Linus