From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jamie Lokier <jamie@shareable.org>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
jens.axboe@oracle.com, akpm@linux-foundation.org,
nickpiggin@yahoo.com.au, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch v3] splice: fix race with page invalidation
Date: Wed, 30 Jul 2008 17:54:20 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.1.10.0807301751320.3277@nehalem.linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0807301746500.3277@nehalem.linux-foundation.org>
On Wed, 30 Jul 2008, Linus Torvalds wrote:
>
> Personally, I think the right approach is to just realize that splice() is
> _not_ a write() system call, and never will be. If you need synchronous
> writing, you simply shouldn't use splice().
Side note: in-kernel users could probably do somethign about this. IOW, if
there's some in-kernel usage (and yes, knfsd would be a prime example),
that one may actually be able to do things that a _user_level user of
splice() could never do.
That includes things like getting the inode semaphore over a write (so
that you can guarantee that pages that are in flight are not modified,
except again possibly by other mmap users), and/or a per-page callback for
when splice() is done with a page (so that you could keep the page locked
while it's getting spliced, for example).
And no, we don't actually have that either, of course.
Linus
next prev parent reply other threads:[~2008-07-31 0:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-30 9:43 [patch v3] splice: fix race with page invalidation Miklos Szeredi
2008-07-30 17:00 ` Linus Torvalds
2008-07-30 17:29 ` Miklos Szeredi
2008-07-30 17:54 ` Jens Axboe
2008-07-30 18:32 ` Miklos Szeredi
2008-07-30 18:43 ` Miklos Szeredi
2008-07-30 19:45 ` Jens Axboe
2008-07-30 20:05 ` Miklos Szeredi
2008-07-30 20:13 ` Linus Torvalds
2008-07-30 20:45 ` Miklos Szeredi
2008-07-30 20:51 ` Linus Torvalds
2008-07-30 21:16 ` Miklos Szeredi
2008-07-30 21:22 ` Linus Torvalds
2008-07-30 21:46 ` Miklos Szeredi
2008-07-30 21:56 ` Linus Torvalds
2008-07-31 0:11 ` Jamie Lokier
2008-07-31 0:42 ` Jamie Lokier
2008-07-31 0:51 ` Linus Torvalds
2008-07-31 0:54 ` Linus Torvalds [this message]
2008-07-31 6:12 ` Jamie Lokier
2008-07-31 10:26 ` Evgeniy Polyakov
2008-07-31 12:33 ` Jamie Lokier
2008-07-31 12:49 ` Nick Piggin
2008-07-31 13:29 ` Evgeniy Polyakov
2008-07-31 16:56 ` Linus Torvalds
2008-07-31 16:34 ` Linus Torvalds
2008-07-31 17:21 ` Jamie Lokier
2008-07-31 18:54 ` Linus Torvalds
2008-07-31 7:30 ` Miklos Szeredi
2008-07-31 2:16 ` Nick Piggin
2008-07-31 12:59 ` Nick Piggin
2008-07-31 17:00 ` Linus Torvalds
2008-07-31 18:13 ` Miklos Szeredi
2008-08-01 1:22 ` Nick Piggin
2008-08-01 18:28 ` Miklos Szeredi
2008-08-01 18:32 ` Linus Torvalds
2008-08-02 4:26 ` Nick Piggin
2008-08-04 15:29 ` Jamie Lokier
2008-08-05 2:57 ` Nick Piggin
2008-08-11 3:22 ` Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.1.10.0807301751320.3277@nehalem.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=jamie@shareable.org \
--cc=jens.axboe@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=miklos@szeredi.hu \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).