Re: [PATCH -v7][RFC]: mutex: implement adaptive spinning

Linus Torvalds
2009-01-10T01:39:46Z

On Sat, 10 Jan 2009, Ingo Molnar wrote:
>
> - 'static inline' functions in .c files that are not used cause no build
> warnings - while if we change them to 'static', we get a 'defined but
> not used' warning. Hundreds of new warnings in the allyesconfig builds.

Well, duh. Maybe they shouldn't be marked "inline", and maybe they should
be marked with "__maybe_unused" instead.

I do not think it makes sense to use "inline" as a way to say "maybe I
won't use this function".

Yes, it's true that "static inline" won't warn, but hey, as a way to avoid
a warning it's a pretty bad one.

Linus