Re: [PATCH 5/8] xfstests: Add fallocate zero range operation to fsstress

["Lukáš Czerner" <lczerner@redhat.com>]

On Fri, 28 Feb 2014, Eric Sandeen wrote:

> Date: Fri, 28 Feb 2014 11:40:08 -0600
> From: Eric Sandeen <sandeen@sandeen.net>
> To: Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org
> Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
> Subject: Re: [PATCH 5/8] xfstests: Add fallocate zero range operation to
>     fsstress
> 
> On 2/28/14, 10:11 AM, Lukas Czerner wrote:
> > This commit adds fzero operation support for fsstress, which is meant to
> > exercise fallocate FALLOC_FL_ZERO_RANGE support.
> > 
> > Also reorganise the common fallocate code into a single do_fallocate()
> > function and use flags use the right mode.
> > 
> > Also in order to make more obvious which fallocate mode fsstress is
> > testing translate fallocate flags into human readable strings.
> 
> Can you enhance that so that if it's passed a flag which isn't
> in the known array, it prints the leftover values?  Otherwise
> they are silently dropped, which might be confusing.
> 
> Handling the case where a flag is not in the array would future-proof
> it, I think.
> 
> -Eric

Yes, I can do that. The only reason I've left this out was to force
people to actually update it when they update the test with new
flag.

Thanks!
-Lukas