From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= Subject: Re: [PATCH] xfstests: f2fs support Date: Tue, 3 Jun 2014 14:49:53 +0200 (CEST) Message-ID: References: <1401717572-21731-1-git-send-email-jaegeuk@kernel.org> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-788635479-1401799797=:2112" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforget.net, xfs@oss.sgi.com To: Jaegeuk Kim Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com List-Id: linux-fsdevel.vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-788635479-1401799797=:2112 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On Tue, 3 Jun 2014, Luk=E1=A8 Czerner wrote: > Date: Tue, 3 Jun 2014 13:32:30 +0200 (CEST) > From: Luk=E1=A8 Czerner > To: Jaegeuk Kim > Cc: Dave Chinner , xfs@oss.sgi.com, > linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, > linux-f2fs-devel@lists.sourceforget.net > Subject: Re: [PATCH] xfstests: f2fs support >=20 > On Mon, 2 Jun 2014, jaegeuk@kernel.org wrote: >=20 > > Date: Mon, 2 Jun 2014 22:59:32 +0900 > > From: jaegeuk@kernel.org > > To: Dave Chinner > > Cc: xfs@oss.sgi.com, linux-kernel@vger.kernel.org, > > linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge= t.net, > > Jaegeuk Kim > > Subject: [PATCH] xfstests: f2fs support > >=20 > > From: Jaegeuk Kim > >=20 > > This patch adds to support f2fs file system. >=20 > Hi, >=20 > Looks good. >=20 > Signed-off-by: Lukas Czerner >=20 Oops, wrong macro. I meant to say Reviewed-by: Lukas Czerner > Btw dry run option in fsck is quite useful here because when the > file system gets corrupted you do not want it to get fixed, but > rather investigate the corrupted file system to figure out what > happened. But of course it's not required :) >=20 > However after a quick look at you fsck code it seems that you do not > attempt to fix anything at all... >=20 > Also having mkfs to check for existing signatures on the device > before attempting to create the file system is a good thing to do > (at least xfs, btrfs extN are doing so) to avoid data loss by > mistake. You can use libblkid from util-linux and it's very simple > to use. >=20 > Thanks! > -Lukas >=20 > >=20 > > Signed-off-by: Jaegeuk Kim > > --- > > common/config | 7 +++++++ > > common/rc | 6 ++++++ > > 2 files changed, 13 insertions(+) > >=20 > > diff --git a/common/config b/common/config > > index 0dbf0b9..0607294 100644 > > --- a/common/config > > +++ b/common/config > > @@ -210,6 +210,7 @@ case "$HOSTOS" in > > export MKFS_XFS_PROG=3D"`set_prog_path mkfs.xfs`" > > export MKFS_UDF_PROG=3D"`set_prog_path mkudffs`" > > export MKFS_BTRFS_PROG=3D"`set_btrfs_mkfs_prog_path_with_opt= s`" > > + export MKFS_F2FS_PROG=3D"`set_prog_path mkfs.f2fs`" > > export BTRFS_UTIL_PROG=3D"`set_prog_path btrfs`" > > export BTRFS_SHOW_SUPER_PROG=3D"`set_prog_path btrfs-show-su= per`" > > export XFS_FSR_PROG=3D"`set_prog_path xfs_fsr`" > > @@ -241,6 +242,9 @@ _mount_opts() > > # acls & xattrs aren't turned on by default on ext$FOO > > export MOUNT_OPTIONS=3D"-o acl,user_xattr $EXT_MOUNT_OPTIONS" > > ;; > > + f2fs) > > + export MOUNT_OPTIONS=3D"-o acl,user_xattr $F2FS_MOUNT_OPTIONS" > > + ;; > > reiserfs) > > # acls & xattrs aren't turned on by default on reiserfs > > export MOUNT_OPTIONS=3D"-o acl,user_xattr $REISERFS_MOUNT_OPTIONS" > > @@ -295,6 +299,9 @@ _fsck_opts() > > reiserfs) > > export FSCK_OPTIONS=3D"--yes" > > ;; > > + f2fs) > > + export FSCK_OPTIONS=3D"" > > + ;; > > *) > > export FSCK_OPTIONS=3D"-n" > > ;; > > diff --git a/common/rc b/common/rc > > index f27ee53..fcdabfe 100644 > > --- a/common/rc > > +++ b/common/rc > > @@ -105,6 +105,9 @@ case "$FSTYP" in > > btrfs) > > [ "$MKFS_BTRFS_PROG" =3D "" ] && _fatal "mkfs.btrfs not found" > > ;; > > + f2fs) > > + [ "$MKFS_F2FS_PROG" =3D "" ] && _fatal "mkfs.f2fs not found" > > + ;; > > nfs) > > ;; > > esac > > @@ -511,6 +514,9 @@ _scratch_mkfs() > > tmpfs) > > # do nothing for tmpfs > > ;; > > + f2fs) > > + $MKFS_F2FS_PROG $MKFS_OPTIONS $* $SCRATCH_DEV > /dev/null > > + ;; > > *) > > yes | $MKFS_PROG -t $FSTYP -- $MKFS_OPTIONS $* $SCRATCH_DEV > > ;; > >=20 > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel= " in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >=20 --8323328-788635479-1401799797=:2112 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs --8323328-788635479-1401799797=:2112--