Re: [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads.

["Lukáš Czerner" <lczerner@redhat.com>]

On Thu, 5 Jun 2014, chishanmingshen wrote:

> Date: Thu,  5 Jun 2014 19:55:09 +0800
> From: chishanmingshen <chishanmingshen@gmail.com>
> To: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: linux-fsdevel@vger.kernel.org, chishanmingshen <chishanmingshen@gmail.com>
> Subject: [RFC 1/1] vfs: del redundant BH_new flag on unrelated buffer heads.
> 
> Just skip the unrelated buffer heads when clear buffer head's BH_new flag.

I can see that from the code, but can you explain why in the commit
description ?

Thanks!
-Lukas

> This patch is *untested*.
> 
> Signed-off-by: chishanmingshen <chishanmingshen@gmail.com>
> ---
>  fs/buffer.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 9ddb9fc..a28a1a1 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -1987,8 +1987,8 @@ static int __block_commit_write(struct inode *inode, struct page *page,
>  		} else {
>  			set_buffer_uptodate(bh);
>  			mark_buffer_dirty(bh);
> +			clear_buffer_new(bh);
>  		}
> -		clear_buffer_new(bh);
>  
>  		block_start = block_end;
>  		bh = bh->b_this_page;
>