From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andreas Dilger <adilger@sun.com>
Cc: David Howells <dhowells@redhat.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-afs@lists.infradead.org
Subject: Re: [PATCH 00/17] [RFC] AFS: Implement OpenAFS pioctls(version)s
Date: Wed, 17 Jun 2009 09:09:47 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0906170901480.16802@localhost.localdomain> (raw)
In-Reply-To: <20090617075502.GB13073@webber.adilger.int>
On Wed, 17 Jun 2009, Andreas Dilger wrote:
>
> What about opening the mountpoint (which HAS to be available) and then
> calling an ioctl() on that?
It's very hard to "open the mountpoint" in user space. How would you even
do it? Remember: we're not living in the 1980's any more, and disco is
dead. ABBA may have made a comeback, but static mountpoints are long gone,
and won't be coming back.
These days, you can mount individual files, you can have per-process
mounts, and automounters have been a fact for a long time.
So I _agree_ that pioctl's are problematic, but please don't argue against
them using _stupid_ arguments. And "open the mountpoint" really is a
stupid argument. It not only isn't possible to do in user space, but you
may well want to do operations on a particular path, not just the mount.
So you'd need to open the file itself. Which might be a symlink or a
device node, depending on the exact semantics of pioctl.
We've traditionally had that magic "open with flag=3" to do a magic open
of device files without waiting, and we have O_NOFOLLOW to open symlinks
without following them (sadly, it just errors out, rather than opening the
symlink, but that's another detail).
So I think it should be solvable some way, but not by trying to find the
mount point.
Linus
next prev parent reply other threads:[~2009-06-17 16:10 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 20:38 [PATCH 00/17] [RFC] AFS: Implement OpenAFS pioctls(version)s David Howells
2009-06-16 20:38 ` [PATCH 01/17] VFS: Implement the pioctl() system call David Howells
2009-06-16 20:54 ` Christoph Hellwig
2009-06-17 0:19 ` David Howells
2009-06-17 9:02 ` Alan Cox
2009-06-16 20:38 ` [PATCH 02/17] VFS: Implement the AFS " David Howells
2009-06-16 20:39 ` [PATCH 03/17] VFS: Implement handling for pathless pioctls David Howells
2009-06-17 7:47 ` Andreas Dilger
2009-06-17 18:26 ` David Howells
2009-06-16 20:39 ` [PATCH 04/17] AFS: Add key request for pioctl David Howells
2009-06-16 20:39 ` [PATCH 05/17] AFS: Handle pathless pioctls aimed at AFS David Howells
2009-06-16 20:39 ` [PATCH 06/17] VFS: Define pioctl command wrappers David Howells
2009-06-16 20:39 ` [PATCH 07/17] AFS: Implement the PGetFid pioctl David Howells
2009-06-16 20:39 ` [PATCH 08/17] AFS: Implement the PGetFileCell pioctl David Howells
2009-06-16 20:39 ` [PATCH 09/17] AFS: Implement the PGetVolStat pioctl David Howells
2009-06-16 20:39 ` [PATCH 10/17] AFS: Implement the PWhereIs pioctl David Howells
2009-06-17 7:51 ` Andreas Dilger
2009-06-17 18:05 ` David Howells
2009-06-16 20:39 ` [PATCH 11/17] AFS: Implement the PFlushCB pioctl David Howells
2009-06-16 20:39 ` [PATCH 12/17] KEYS: Export lookup_user_key() and the key permission request flags David Howells
2009-06-16 20:39 ` [PATCH 13/17] RxRPC: Record extra data in key David Howells
2009-06-16 20:39 ` [PATCH 14/17] RxRPC: Declare the security index constants symbolically David Howells
2009-06-16 20:40 ` [PATCH 15/17] AFS: Implement the PSetTokens pioctl David Howells
2009-06-16 20:40 ` [PATCH 16/17] KEYS: Add a function by which the contents of a keyring can be enumerated David Howells
2009-06-16 20:40 ` [PATCH 17/17] AFS: Implement the PGetTokens pioctl David Howells
2009-06-16 22:59 ` [PATCH 00/17] [RFC] AFS: Implement OpenAFS pioctls(version)s David Howells
2009-06-16 23:11 ` Alan Cox
2009-06-17 0:25 ` David Howells
2009-06-17 7:55 ` Andreas Dilger
2009-06-17 16:09 ` Linus Torvalds [this message]
2009-06-17 18:37 ` Al Viro
2009-06-17 18:44 ` Linus Torvalds
2009-06-17 18:52 ` Al Viro
2009-06-17 19:28 ` David Howells
2009-06-18 12:50 ` Olivier Galibert
2009-06-17 17:24 ` David Howells
2009-06-17 17:33 ` Linus Torvalds
2009-06-17 18:03 ` David Howells
2009-06-17 18:24 ` Linus Torvalds
2009-06-17 18:30 ` Theodore Tso
2009-06-17 19:14 ` david
2009-06-17 19:30 ` David Howells
2009-06-17 19:51 ` David Howells
2009-06-17 20:09 ` Linus Torvalds
2009-06-17 9:00 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0906170901480.16802@localhost.localdomain \
--to=torvalds@linux-foundation.org \
--cc=adilger@sun.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).