From: Linus Torvalds <torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
To: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: Trond Myklebust
<Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org>,
Al Viro <viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>,
Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/5] VFS: Add VFS helper functions for setting up private namespaces
Date: Tue, 23 Jun 2009 19:51:59 -0700 (PDT) [thread overview]
Message-ID: <alpine.LFD.2.01.0906231950030.3240@localhost.localdomain> (raw)
In-Reply-To: <20090623223230.GA30173-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
On Tue, 23 Jun 2009, Serge E. Hallyn wrote:
>
> (it keeps bugging me that the order of args to list_add() gets reversed
> as a result, but clearly with both starting out empty it doesn't
> matter..)
.. and the new one is more logical. "list_add()" really adds the first
entry to the list pointed to by the second one. It _works_ the other way
too in this case, as you point out, but now that you mention it, it really
looks like the pre-patch code is "wrong".
Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-06-24 2:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 19:09 [PATCH 0/5] NFS private namespace patchset Trond Myklebust
2009-06-22 19:09 ` [PATCH 1/5] VFS: Uninline the function put_mnt_ns() Trond Myklebust
2009-06-22 19:09 ` [PATCH 3/5] NFSv4: Replace nfs4_path_walk() with VFS path lookup in a private namespace Trond Myklebust
[not found] ` <20090622190913.27923.31665.stgit-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-06-22 19:09 ` [PATCH 2/5] VFS: Add VFS helper functions for setting up private namespaces Trond Myklebust
[not found] ` <20090622190913.27923.61549.stgit-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-06-23 20:13 ` Serge E. Hallyn
[not found] ` <20090623201307.GA25760-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-23 21:29 ` Trond Myklebust
2009-06-23 22:32 ` Serge E. Hallyn
[not found] ` <20090623223230.GA30173-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-24 2:51 ` Linus Torvalds [this message]
2009-06-22 19:09 ` [PATCH 5/5] NFS: Correct the NFS mount path when following a referral Trond Myklebust
[not found] ` <20090622190914.27923.84173.stgit-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2009-06-23 20:42 ` Serge E. Hallyn
[not found] ` <20090623204202.GA25969-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-06-23 21:15 ` Trond Myklebust
2009-06-22 19:09 ` [PATCH 4/5] NFS: Fix nfs_path() to always return a '/' at the beginning of the path Trond Myklebust
2009-06-22 19:40 ` [PATCH 0/5] NFS private namespace patchset Linus Torvalds
2009-06-23 21:33 ` Al Viro
[not found] ` <20090623213309.GK8633-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2009-06-23 21:40 ` Linus Torvalds
2009-06-23 23:22 ` Al Viro
2009-06-24 12:58 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.01.0906231950030.3240@localhost.localdomain \
--to=torvalds-de/tnxtf+jlsfhdxvbkv3wd2fqjk+8+b@public.gmane.org \
--cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=viro-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).