From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:19509 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752513AbdKMU7v (ORCPT ); Mon, 13 Nov 2017 15:59:51 -0500 Date: Tue, 14 Nov 2017 07:58:45 +1100 (AEDT) From: James Morris To: "Luis R. Rodriguez" cc: Mimi Zohar , David Howells , linux-integrity , linux-fsdevel , linux-kernel , Andy Lutomirski , James Bottomley , David Woodhouse , Kyle McMartin , Ben Hutchings , Alan Cox , Greg Kroah-Hartman , Linus Torvalds , Kees Cook , "AKASHI, Takahiro" Subject: Re: [RFC PATCH v2] fw_lockdown: new micro LSM module to prevent loading unsigned firmware In-Reply-To: <20171113195154.GE22894@wotan.suse.de> Message-ID: References: <1510573414.3404.109.camel@linux.vnet.ibm.com> <20171113190505.GC22894@wotan.suse.de> <1510601807.3711.16.camel@linux.vnet.ibm.com> <20171113195154.GE22894@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 13 Nov 2017, Luis R. Rodriguez wrote: > > > > -#define SECURITY_NAME_MAX 10 > > > > +#define SECURITY_NAME_MAX 15 > > > > > > Should this small hunk be a separate atomic patch? > > > > I thought about it, but this is the first and only LSM with a larger > > name. > > Maybe the commit log should mention that then. Actually, make it a separate patch, so we can easily pinpoint the commit. -- James Morris