From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from tundra.namei.org ([65.99.196.166]:37358 "EHLO namei.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755651AbbLAJxx (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
	Tue, 1 Dec 2015 04:53:53 -0500
Date: Tue, 1 Dec 2015 20:53:07 +1100 (AEDT)
From: James Morris <jmorris@namei.org>
To: Andreas Gruenbacher <agruenba@redhat.com>
cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 10/10] xattr handlers: Simplify list operation
In-Reply-To: <1448919823-27103-11-git-send-email-agruenba@redhat.com>
Message-ID: <alpine.LRH.2.20.1512012052110.15599@namei.org>
References: <1448919823-27103-1-git-send-email-agruenba@redhat.com> <1448919823-27103-11-git-send-email-agruenba@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Mon, 30 Nov 2015, Andreas Gruenbacher wrote:

> diff --git a/fs/ocfs2/xattr.c b/fs/ocfs2/xattr.c
> index 906022d..61dd93f 100644
> --- a/fs/ocfs2/xattr.c
> +++ b/fs/ocfs2/xattr.c
> @@ -895,6 +895,8 @@ static int ocfs2_xattr_list_entry(char *buffer, size_t size,
>  
>  	*result += total_len;
>  
> +	/* FIXME: Not checking the ->list operation here ... */
> +

What does this mean? 

-- 
James Morris
<jmorris@namei.org>