From: Hugh Dickins <hughd@google.com>
To: Jan Kara <jack@suse.cz>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>, Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@infradead.org>,
Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/15] writeback: remove writeback_control.more_io
Date: Wed, 13 Jul 2011 08:06:26 -0700 (PDT) [thread overview]
Message-ID: <alpine.LSU.2.00.1107130804430.4820@sister.anvils> (raw)
In-Reply-To: <20110713111928.GA21787@quack.suse.cz>
On Wed, 13 Jul 2011, Jan Kara wrote:
> On Wed 13-07-11 03:57:40, Hugh Dickins wrote:
> >
> > I think we should assume that your -requeue_io +redirty_tail is a good
> > fix for the writeback freeze (if you can reassure us, that it does not
> > risk postponing some writes indefinitely)
> Well, I_FREEING or I_WILL_FREE inodes are written back by iput_final()
> and it is reclaim code that is responsible for eventually removing them. So
> writeback code can safely ignore them. I_NEW inodes should move out of this
> state when they are fully set up and in the writeback round following that,
> we will consider them for writeback. So I think the change really makes
> sense.
That fits. Good, thanks for the reassurance.
Hugh
next prev parent reply other threads:[~2011-07-13 15:06 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 21:32 [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5) Wu Fengguang
2011-06-07 21:32 ` [PATCH 01/15] writeback: introduce .tagged_writepages for the WB_SYNC_NONE sync stage Wu Fengguang
2011-06-07 23:02 ` Andrew Morton
2011-06-07 23:24 ` Wu Fengguang
2011-06-07 21:32 ` [PATCH 02/15] writeback: update dirtied_when for synced inode to prevent livelock Wu Fengguang
2011-06-07 23:02 ` Andrew Morton
2011-06-07 23:51 ` Wu Fengguang
2011-06-07 21:32 ` [PATCH 03/15] writeback: introduce writeback_control.inodes_cleaned Wu Fengguang
2011-06-07 23:03 ` Andrew Morton
2011-06-08 0:10 ` Wu Fengguang
2011-06-07 21:32 ` [PATCH 04/15] writeback: try more writeback as long as something was written Wu Fengguang
2011-06-07 21:32 ` [PATCH 05/15] writeback: the kupdate expire timestamp should be a moving target Wu Fengguang
2011-06-07 21:32 ` [PATCH 06/15] writeback: refill b_io iff empty Wu Fengguang
2011-06-07 21:32 ` [PATCH 07/15] writeback: split inode_wb_list_lock into bdi_writeback.list_lock Wu Fengguang
2011-06-07 23:03 ` Andrew Morton
2011-06-08 0:20 ` Wu Fengguang
2011-06-08 0:35 ` Andrew Morton
2011-06-08 1:36 ` Wu Fengguang
2011-06-07 21:32 ` [PATCH 08/15] writeback: elevate queue_io() into wb_writeback() Wu Fengguang
2011-06-07 21:32 ` [PATCH 09/15] writeback: avoid extra sync work at enqueue time Wu Fengguang
2011-06-07 21:32 ` [PATCH 10/15] writeback: add bdi_dirty_limit() kernel-doc Wu Fengguang
2011-06-07 21:32 ` [PATCH 11/15] writeback: skip balance_dirty_pages() for in-memory fs Wu Fengguang
2011-06-11 13:07 ` Wu Fengguang
2011-06-13 13:42 ` Jan Kara
2011-06-07 21:32 ` [PATCH 12/15] writeback: remove writeback_control.more_io Wu Fengguang
2011-07-11 21:31 ` Hugh Dickins
2011-07-12 6:20 ` Wu Fengguang
2011-07-12 19:50 ` Hugh Dickins
2011-07-13 5:49 ` Hugh Dickins
2011-07-13 10:57 ` Hugh Dickins
2011-07-13 11:19 ` Jan Kara
2011-07-13 15:06 ` Hugh Dickins [this message]
2011-07-13 22:07 ` Wu Fengguang
2011-06-07 21:32 ` [PATCH 13/15] writeback: remove .nonblocking and .encountered_congestion Wu Fengguang
2011-06-07 21:32 ` [PATCH 14/15] writeback: trace event writeback_single_inode Wu Fengguang
2011-06-07 21:32 ` [PATCH 15/15] writeback: trace event writeback_queue_io Wu Fengguang
2011-06-07 23:04 ` [PATCH 00/15] writeback fixes and cleanups for 3.0 (v5) Andrew Morton
2011-06-08 2:01 ` Wu Fengguang
2011-06-08 6:21 ` Sedat Dilek
2011-06-08 13:45 ` Wu Fengguang
2011-06-09 1:16 ` Stephen Rothwell
2011-06-09 2:18 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LSU.2.00.1107130804430.4820@sister.anvils \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=david@fromorbit.com \
--cc=fengguang.wu@intel.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox