From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795007428; b=CJAqPN828C4n4Um2Rhzf3vxTR9BWKGQM6ykiXtGLH1L2ONiOS2LRIVfurRfc06vAO9by UEF4iSB2l9VOCJ0/U1Ag8L2MXOtHm9b2ji5VjjokqOo9HAMWyehKINpwRAnFmwFkAxvGr vc9Ei8VBZ1yjCmpCQzAppNh57U1hE2jYhlhDGrWGp20jv2yltT9voRbvrp4SckPLwRMUf NKbeUrsEq2pIeSAZMP7b6mI333rkm/RT13fm+/90kSlmzBNM+JlGvgxbJsJhKWgnKFIB2 tXSAQIe2tBGRwEokfBiYwbc2pvgmB2lP0HAdZWJEMTDF9F3PzTrwjQuVxH3itJZyNag== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795007428; h=DMARC-Filter:DKIM-Signature:Received:X-MC-Unique: X-Mimecast-MFC-AGG-ID:Received:Received:Received:Date:From:To:Cc: Subject:Message-ID:References:MIME-Version:Content-Type: Content-Disposition:In-Reply-To:X-Scanned-By; bh=SW1SgyAqJZMhz2Qvs3jWCWx5VKPPmPyNUr3G/FpCRlc=; b=XY/VoMOIxCjElRVvfCl4Hi9rAvxtY6sGEkVPBysE65W374fIhxwAPr3uuFZCSdBBh8OJ I3YeRZdF0ynbOnSyp+V6CKffszLQG48W3zPGw4+lw51ZTVVRefrZnpYixeJRI/VWrqrAm m+lpoF1sSSQkYlsZO59klrhXDeXjdYAwicX8wvtGiqLRHuNLrAUkNFlqplKrAN3SiwkpM gUTOZgaMrxA+RgOycwsPdnS/Gj7e95bFyzuY8VSwuBNCQ3yWJU9cD0xYvYGBOjMeKWVXh 7123CA3ST9rrzimKIgm2GHNXMkH5qvJDaY+3VaoKQUj7t+8mofI3OklNnEnmfpD0fkA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YduyURg5; arc=none smtp.remote-ip=170.10.133.124 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363B8606A320 for ; Wed, 18 Nov 2026 13:10:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 363B8606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=YduyURg5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1795007427; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SW1SgyAqJZMhz2Qvs3jWCWx5VKPPmPyNUr3G/FpCRlc=; b=YduyURg5hVTIPnCeh5e3XQHUkQs8szl2sdUVFc/Dwkmwg3Z+fNfJm4WoENvc+V+h9Z+8FC HGjhDMs7KkE8v1LqziZRNsXGYYTu+KhL9TK04MItaa8UJyW+4UrkNy/plsHw4IG5z1NS/F Fl1FOaxpoW96nrw85XSSiQUZX28HjWE= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-520-PSY9HXz-MPSmoDPTNZ-_8Q-1; Wed, 18 Nov 2026 08:10:25 -0500 X-MC-Unique: PSY9HXz-MPSmoDPTNZ-_8Q-1 X-Mimecast-MFC-AGG-ID: PSY9HXz-MPSmoDPTNZ-_8Q_1795007423 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1105919560B1; Wed, 18 Nov 2026 13:10:23 +0000 (UTC) Received: from onestero-thinkpadp1gen7.tpbc.csb (headnet04.pony-001.prod.iad2.dc.redhat.com [10.2.32.116]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 4D8A23000223; Wed, 18 Nov 2026 13:10:18 +0000 (UTC) Received: by onestero-thinkpadp1gen7.tpbc.csb (nbSMTP-1.00) for uid 13628 oleg@redhat.com; Wed, 18 Nov 2026 14:10:22 +0100 (CET) Date: Wed, 18 Nov 2026 14:10:17 +0100 From: Oleg Nesterov To: Linus Torvalds Cc: Mani Tofigh via B4 Relay , Breno Leitao , Christian Brauner , Mateusz Guzik , Alexander Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, tz2294@columbia.edu, stable@vger.kernel.org, Mani Tofigh Subject: Re: [PATCH] pipe: keep per-write wakeups for EPOLLEXCLUSIVE consumers Message-ID: References: <20261111-pipe-epollexclusive-wakeup-v1-1-0af6283e9fda@columbia.edu> X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 11/17, Linus Torvalds wrote: > > That header isn't _horrible_, but some of it was uglier than needed, > and adding WQ_FLAG_PRIORITY would have been a huge pain because the > code unnecessarily special-cases WQ_FLAG_EXCLUSIVE. Yes. See also below. > NOTE! Entirely untested. Comments? I tried to check it line-by-line, see nothing wrong. FWIW, Reviewed-by: Oleg Nesterov --------------------------------------------------------------------------- And this reminds me. Please look at __wait_event_interruptible_locked(), it is buggy. do_wait_intr() and do_wait_intr_irq() use __add_wait_queue_entry_tail() regardless of WQ_FLAG_EXCLUSIVE (reported by Mani in another thread). Plus another problem: exclusive waiter must not fail if it was selected by wakeup, see the comment in prepare_to_wait_event(). What if we add, say, WQ_FLAG_LOCKED and change prepare_to_wait_event() --- x/kernel/sched/wait.c +++ x/kernel/sched/wait.c @@ -274,7 +274,8 @@ long prepare_to_wait_event(struct wait_q unsigned long flags; long ret = 0; - spin_lock_irqsave(&wq_head->lock, flags); + if (!(wq_entry->flags & WQ_FLAG_LOCKED)) + spin_lock_irqsave(&wq_head->lock, flags); if (signal_pending_state(state, current)) { /* * Exclusive waiter must not fail if it was selected by wakeup, @@ -299,7 +300,8 @@ long prepare_to_wait_event(struct wait_q } set_current_state(state); } - spin_unlock_irqrestore(&wq_head->lock, flags); + if (!(wq_entry->flags & WQ_FLAG_LOCKED)) + spin_unlock_irqrestore(&wq_head->lock, flags); return ret; } ? Yes, finish_wait() needs to check WQ_FLAG_LOCKED too... perhaps just if (WQ_FLAG_LOCKED) list_del_init(...); at the start. Then we can trivially redefine all users of __wait_event_interruptible_locked() on top of ___wait_event/etc. Say, wait_event_interruptible_exclusive_locked(wq, condition) can use ___wait_event(wq, condition, TASK_INTERRUPTIBLE, WQ_FLAG_EXCLUSIVE | WQ_FLAG_LOCKED, spin_unlock(&wq->lock); schedule(); spin_lock(&wq->lock)) Will you agree with this hack? If yes, I'll try to make the patch on top of your cleanup. Oleg.