From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.41 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794396719; b=VNNzUvwMPSlf2NUffAEWrPU9vZLGbNNkRH5Yo8ZP0wJ1r2WK6ku4lJEAxrSVO2zTY7Af dx1ZF+XSip6JjRoj3om1GqbPk/thKPPw5I7R0KlvhMHiC7yJoWua25mvVWVSDDsKjXl5R zMXX1K4Y+Vx9dMcZ5sQnMa/u3k7f8DgIIsxTJ60M144afm9HQIjzXDvwCSgusBpuPXT9H 9lB9CQDld0qQN3LiVK5fQW/dp5CPWpxYNqXw/RLdg9AdxfTp6JDlm3S4SSvMWEshKtBY5 oDC7yUTXbAvpBTMHLpvF1iJM4DycuzRw7BqoIPADkdF8KLtlmHK7myu+k6E/BfTpSJg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794396719; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=35V3MBb3/B+i0WSH1JZearQNILa3rdNf4KCJ9ar7n0Y=; b=fwQoXO7LVy8oPvqTvLCTyNdtIcFB+okG4dbL7xSBMq0FSbecCgWCna8nZKVHHrQDDisG KnBRw2lWVuOTfqFe8KB1O4GImpPZSqY3Lg29+H488LOO+nGH3egLsXJydJk1xTDI2xhCH HwgSnVF8OLvyr8kGTLKp/WMQyrYVRIyR/Su7/I/J+lil1VGxpMyfgvwRyg1I8wh9oQIZH KtYQ73FZNTmP3TrsRdMKldtQ9qcSkathD2jMMC1zb+aJO9Gy+NY/qf8+j4BugSHJRwHN6 oVLe2H7W1jYOEFMYiNvr4yJ0iDby5AKcfbAG98rLOF24aJOkVvRR+35aSOpcHqDoXYg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=obfStFx7; arc=none smtp.remote-ip=95.215.58.41 Received: from mta1.migadu.com (out-41.mta1.migadu.com [95.215.58.41]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C28A4606A324 for ; Wed, 11 Nov 2026 11:31:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org C28A4606A324 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=obfStFx7 X-Envelope-To: linux-fsdevel@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=oqWUGVElRBr5oQDm9wyWE9Xl/dvm1ksZ5tyenrhg2NY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1794396716; v=1; x=1795001516; b=obfStFx7nGxEJk0Bi6v0awaFc19JwMkH56pO5pke9JK9Kq6n+6cIqv5gwi9RP7bkKiLP2RGA YcusUgS9EPQgjDXmwlCdrqQ+AoC2qINVuXePAOzMsXD+51J2F8TfCssGQYRrLg0iAZWo9obGi48 +VnUnDKr7wV0hMNRGT9eIEaM= X-Envelope-To: linux-fsdevel@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 7e5b0a92b0c43409; Wed, 11 Nov 2026 11:31:56 +0000 X-Mizu-Trace-ID: 7e5b0a92b0c43409 X-Migadu-Flow: FLOW_OUT Date: Wed, 11 Nov 2026 12:31:52 +0100 From: "Pankaj Raghav (Samsung)" To: Christoph Hellwig Cc: Carlos Maiolino , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 16/25] xfs: add support for reading with data checksums Message-ID: References: <20261104085929.317544-1-hch@lst.de> <20261104085929.317544-17-hch@lst.de> X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261104085929.317544-17-hch@lst.de> On Wed, Nov 04, 2026 at 09:57:20AM +0100, Christoph Hellwig wrote: > All reads from files with data checksums have the returned iomaps for > data blocks limited to be inside a single RT csum file block, so that > each data read only needs to deal with a single checksum buffer. > > All reads on checksummed files need to use ioends so that the checksum > can be verified from process context. The ioend submission path looks > up the checksum buffer and kicks of an asynchronous read of it. The > completion path waits for the buffer if needed and verifies the checksum. > > Signed-off-by: Christoph Hellwig > --- > fs/xfs/xfs_aops.c | 3 +- > fs/xfs/xfs_ioend.c | 120 +++++++++++++++++++++++++++++++++++++++------ > fs/xfs/xfs_iomap.c | 23 +++++++-- > 3 files changed, 126 insertions(+), 20 deletions(-) > > diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c > index c30e688cfc9f..db834e5e60c1 100644 > --- a/fs/xfs/xfs_aops.c > +++ b/fs/xfs/xfs_aops.c > @@ -601,7 +601,8 @@ xfs_get_iomap_read_ops( > { > struct xfs_inode *ip = XFS_I(mapping->host); > > - if (bdev_has_integrity_csum(xfs_inode_buftarg(ip)->bt_bdev)) > + if (xfs_has_rtcsum(ip->i_mount) || Shouldn't this be xfs_is_rtcsum_inode(ip) instead of a per mount option? > + bdev_has_integrity_csum(xfs_inode_buftarg(ip)->bt_bdev)) > return &xfs_iomap_read_ops; > return &iomap_bio_read_ops; > } -- Pankaj