From: "Kiryl Shutsemau (Meta)" <kas@kernel.org>
To: Usama Arif <usama.arif@linux.dev>
Cc: Andrew Morton <akpm@linux-foundation.org>,
apopple@nvidia.com, byungchul@sk.com, david@kernel.org,
gourry@gourry.net, jannh@google.com, joshua.hahnjy@gmail.com,
liam@infradead.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
ljs@kernel.org, matthew.brost@intel.com, mhocko@suse.com,
pfalcato@suse.de, rppt@kernel.org, surenb@google.com,
vbabka@kernel.org, ying.huang@linux.alibaba.com, ziy@nvidia.com,
hannes@cmpxchg.org, riel@surriel.com, shakeel.butt@linux.dev,
kernel-team@meta.com, baolin.wang@linux.alibaba.com,
Nico Pache <nico.pache@linux.dev>,
ryan.roberts@arm.com, dev.jain@arm.com, baohua@kernel.org,
lance.yang@linux.dev, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/4] mm: don't PTE-batch a swap-in of a folio with a hardware-poisoned page
Date: Tue, 17 Nov 2026 11:02:41 +0000 [thread overview]
Message-ID: <avwwMyk462raQFy2@shutemov.name> (raw)
In-Reply-To: <20261116063624.1382944-3-usama.arif@linux.dev>
On Sun, Nov 15, 2026 at 10:34:56PM -0800, Usama Arif wrote:
> do_swap_page() checks PageHWPoison() on the faulting page, but the
> large-folio batching path then maps the rest of the folio without
> looking at its other pages. A poisoned page that is not the one being
> faulted gets mapped anyway, and the fault that would have reported it
> never happens.
>
> Skip batching for such an anon folio and let each page take its own
> fault, where the existing check catches it. do_set_pmd() already backs
> off the same way.
>
> Leave a freshly read folio alone: it is not anon yet and can only be
> mapped as a whole, and falling back would free it with the poisoned
> page still in it, which the retried fault can then get back from the
> page allocator.
>
> Fixes: 508758960b8d ("mm: swap: entirely map large folios found in swapcache")
> Cc: stable@vger.kernel.org
> Signed-off-by: Usama Arif <usama.arif@linux.dev>
With the check moved up as David and Zi suggested:
Reviewed-by: Kiryl Shutsemau (Meta) <kas@kernel.org>
Do we have the same problem on the file side?
If memory_failure() cannot split a large file folio, it stays in the
page cache with the poisoned page in it.
Consider a write fault through MAP_SHARED on a good page of that folio:
do_shared_fault()
__do_fault()
PageHWPoison(vmf->page)
// checks the faulting page only
finish_fault()
do_set_pmd()
folio_test_has_hwpoisoned(folio)
// backs off with VM_FAULT_FALLBACK
set_pte_range(vmf, folio, &folio->page, folio_nr_pages(folio), addr)
// maps the poisoned page as well
Possible fix is below. I can post a proper patch if the analysis looks
correct.
diff --git a/mm/memory.c b/mm/memory.c
index fb76d8922e37..25b53847943f 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -5893,6 +5893,10 @@ vm_fault_t finish_fault(struct vm_fault *vmf)
return ret;
}
+ /* A poisoned page must take its own fault */
+ if (folio_contain_hwpoisoned_page(folio))
+ needs_fallback = true;
+
if (!needs_fallback && vma->vm_file) {
struct address_space *mapping = vma->vm_file->f_mapping;
pgoff_t file_end;
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2026-11-17 11:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 6:34 [PATCH v2 0/4] mm: fixes for THP migration, swap-in and device-private smaps Usama Arif
2026-11-16 6:34 ` [PATCH v2 1/4] mm/migrate_device: avoid leaking folio references during THP splitting Usama Arif
2026-11-16 18:44 ` David Hildenbrand (Arm)
2026-11-17 10:33 ` Kiryl Shutsemau (Meta)
2026-11-16 18:58 ` Zi Yan
2026-11-16 6:34 ` [PATCH v2 2/4] mm: don't PTE-batch a swap-in of a folio with a hardware-poisoned page Usama Arif
2026-11-16 18:33 ` Joshua Hahn
2026-11-16 18:45 ` David Hildenbrand (Arm)
2026-11-16 19:31 ` Zi Yan
2026-11-17 11:02 ` Kiryl Shutsemau (Meta) [this message]
2026-11-16 6:34 ` [PATCH v2 3/4] fs/proc/task_mmu: don't read young/dirty from a non-present PMD in smaps Usama Arif
2026-11-17 11:08 ` Kiryl Shutsemau (Meta)
2026-11-16 6:34 ` [PATCH v2 4/4] fs/proc/task_mmu: account device-private PMDs as present " Usama Arif
2026-11-17 11:13 ` Kiryl Shutsemau (Meta)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avwwMyk462raQFy2@shutemov.name \
--to=kas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=byungchul@sk.com \
--cc=david@kernel.org \
--cc=dev.jain@arm.com \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=jannh@google.com \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=lance.yang@linux.dev \
--cc=liam@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=matthew.brost@intel.com \
--cc=mhocko@suse.com \
--cc=nico.pache@linux.dev \
--cc=pfalcato@suse.de \
--cc=riel@surriel.com \
--cc=rppt@kernel.org \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=stable@vger.kernel.org \
--cc=surenb@google.com \
--cc=usama.arif@linux.dev \
--cc=vbabka@kernel.org \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox