From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81F5C396D30; Wed, 25 Mar 2026 10:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774433851; cv=none; b=EE2AaGf9FT0CgWjZjiSV8iSr3Bm5eIf8UArVQ2TFGibMm/plx7sey/hAvfCXpKY1WD8yGXWKId8DGwLGmJa+sysOCLs0EMVnqlJeT1DO+6tSfVty0q2Wx6pUx6Tfdfv183zIvnVCWIaj8dPeue75idV6SS90MQzQ9SHcln+uXFM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774433851; c=relaxed/simple; bh=nA0qfgO+czMrdsJFZWiTSPRkj/MhdlMkek+0+cH4SK4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EXS7+kLcNPh33MmnPteOsQUhgz8K4FKIBH2Wx/PAckmH051oL9k18kvAP1DJfFEpVUYjQtmKfH/ApJ5tMjeNFPdV1fbP45O+EZ/p7W8phEqjWgZRIXrsqiUeHFY69RGWRyqbWX0aHgG/qjfFL8z0kLy6/ZEzihmOfEkx4Ron0Eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FsbzuEFD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FsbzuEFD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42BACC4CEF7; Wed, 25 Mar 2026 10:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1774433851; bh=nA0qfgO+czMrdsJFZWiTSPRkj/MhdlMkek+0+cH4SK4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=FsbzuEFDSLYe92S3XWu8yA78sOY17+zhlf5fynvhqSJTYFYJw6q0esNFUoK8ipb2a u7R0mqK8LQby4NecGDUI2pWioR+y7am2SLggsBspBeZ15yYpkkr0SBGpm886/RhHiN rad5UyakBWpkFvgRnnO3d8ty5mH43/XtNctbuFlXr+pC2FE4a3ufJUm13vdWVqj8co 4Skreuix3aAhO5na1RQSvBFefxTvYLO7FZ0K5/iflLUiCqXO4VIdN7LbTK0OrRu670 3FJ2hxkm9GwTrZwAenqnMthnSBKw3cgrQZw56I9+c3uoT2QVqVKcJOz1Sp0xitGyIg 3yAvaJsltHt+A== Message-ID: Date: Wed, 25 Mar 2026 11:17:21 +0100 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/21] hpet: replace deprecated mmap hook with mmap_prepare Content-Language: en-US To: "Lorenzo Stoakes (Oracle)" , Andrew Morton Cc: Jonathan Corbet , Clemens Ladisch , Arnd Bergmann , Greg Kroah-Hartman , "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Bodo Stroesser , "Martin K . Petersen" , David Howells , Marc Dionne , Alexander Viro , Christian Brauner , Jan Kara , David Hildenbrand , "Liam R . Howlett" , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-staging@lists.linux.dev, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, Ryan Roberts References: <094c5fcfb2459a4f6d791b1fb852b01e252a44d4.1774045440.git.ljs@kernel.org> From: "Vlastimil Babka (SUSE)" In-Reply-To: <094c5fcfb2459a4f6d791b1fb852b01e252a44d4.1774045440.git.ljs@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/20/26 23:39, Lorenzo Stoakes (Oracle) wrote: > The f_op->mmap interface is deprecated, so update driver to use its > successor, mmap_prepare. > > The driver previously used vm_iomap_memory(), so this change replaces it > with its mmap_prepare equivalent, mmap_action_simple_ioremap(). > > Reviewed-by: Suren Baghdasaryan > Signed-off-by: Lorenzo Stoakes (Oracle) Acked-by: Vlastimil Babka (SUSE) > --- > drivers/char/hpet.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c > index 60dd09a56f50..8f128cc40147 100644 > --- a/drivers/char/hpet.c > +++ b/drivers/char/hpet.c > @@ -354,8 +354,9 @@ static __init int hpet_mmap_enable(char *str) > } > __setup("hpet_mmap=", hpet_mmap_enable); > > -static int hpet_mmap(struct file *file, struct vm_area_struct *vma) > +static int hpet_mmap_prepare(struct vm_area_desc *desc) > { > + struct file *file = desc->file; > struct hpet_dev *devp; > unsigned long addr; > > @@ -368,11 +369,12 @@ static int hpet_mmap(struct file *file, struct vm_area_struct *vma) > if (addr & (PAGE_SIZE - 1)) > return -ENOSYS; > > - vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot); > - return vm_iomap_memory(vma, addr, PAGE_SIZE); > + desc->page_prot = pgprot_noncached(desc->page_prot); > + mmap_action_simple_ioremap(desc, addr, PAGE_SIZE); > + return 0; > } > #else > -static int hpet_mmap(struct file *file, struct vm_area_struct *vma) > +static int hpet_mmap_prepare(struct vm_area_desc *desc) > { > return -ENOSYS; > } > @@ -710,7 +712,7 @@ static const struct file_operations hpet_fops = { > .open = hpet_open, > .release = hpet_release, > .fasync = hpet_fasync, > - .mmap = hpet_mmap, > + .mmap_prepare = hpet_mmap_prepare, > }; > > static int hpet_is_known(struct hpet_data *hdp)