From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH v2] proc: Escape more characters in /proc/mounts output
Date: Wed, 16 Dec 2020 10:55:16 +0530 [thread overview]
Message-ID: <b13c0b71-dd3b-4a2b-1fc7-16d6fea36d46@gotplt.org> (raw)
In-Reply-To: <20201216043323.GM3579531@ZenIV.linux.org.uk>
On 12/16/20 10:03 AM, Al Viro wrote:
> Once more, with feeling: why bother? What's wrong
> with using the damn strndup_user() and then doing
> whatever checks you want with the data already
> copied, living in normal kernel memory, with all
> string functions applicable, etc.?
I was trying to avoid the allocation, but I reckon it is pointless to
micro-optimize the invalid case. I'll send v3.
Siddhesh
prev parent reply other threads:[~2020-12-16 5:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 12:53 [PATCH v2] proc: Escape more characters in /proc/mounts output Siddhesh Poyarekar
2020-12-16 4:33 ` Al Viro
2020-12-16 5:25 ` Siddhesh Poyarekar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b13c0b71-dd3b-4a2b-1fc7-16d6fea36d46@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=fweimer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).