From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 666AF1E502 for ; Tue, 1 Jul 2025 16:19:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751386799; cv=none; b=ktjrD3RApL4FzqVCS3cKKPWqazvlvRr3fEvK6r+MiDQj+931Oprq6dMMncRh2mja1CIHlQT3zlCAyc4KaWP5tlurUOwfGemVLF1/geXlQd9AWeAqKCJ6RM2RRMBDBFCrO68k0iZvJAwnqpYjYGPqCS55slZV659p22F1a+F5r1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751386799; c=relaxed/simple; bh=zERKkaBVA01QeEEJAAMKNa1asJWSr/jVIILAqrrIZ60=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=a0lU2XJbUl1nPK54Ajhq/rtB+2BhyKLE5pFOsJIgrLtBTXK6abOfNIdOLsw8nYmT29hVBl0XulMjRDaosVm3QwakCsuYqNvTHji/fmE2Rx2tlKQWAdpW06GCDrMLfIzYiL2uBwODLPUCrcUQESQfOgrWpR6M/3tWIDRtEOBiu/w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=H4WQXoWy; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H4WQXoWy" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751386796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=prvx9QgvrkS6/HrNRjUGuyIwIbKu9TUrg+VFzDZXD4A=; b=H4WQXoWykyFVS7IEpRflI2JHrNpkSMlHFxJ/551hG6cdS+pRWa8XuGbUHblMOTn2ahHG+B 7AKYcNbhP/DcC0KQWexWhQmBCq9HsVijzCmO9KLszIRfAjaEoDitXoMfT/EA0Vte8y+BKD xRnsaI4HzPJtts3OIA3dXij+zUEaY/g= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688--F43IEggMKG0BzD-xqww9w-1; Tue, 01 Jul 2025 12:19:44 -0400 X-MC-Unique: -F43IEggMKG0BzD-xqww9w-1 X-Mimecast-MFC-AGG-ID: -F43IEggMKG0BzD-xqww9w_1751386783 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3a5780e8137so3351332f8f.1 for ; Tue, 01 Jul 2025 09:19:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751386783; x=1751991583; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=prvx9QgvrkS6/HrNRjUGuyIwIbKu9TUrg+VFzDZXD4A=; b=gjDJFZK0/sHgIDflBqJGCmvgvGYbWCQvpTsWfVPRA6Y3SI7ShT9Q2JWnVL569EnY/c B9X6oROHdgmbg2Pl3Sk7SzeuNpEP8fX7tU2Zisr9aTaj6ibiQ6rm/zHb6gLaZzTpvjRz dsSI/7sk2CTobawBA9731KcnUxO3C4lSPdMsxFke3kI2NYjjxAkvJqiOycjQtp54QkHN gJ4pKObDewP795dwqRg6MjiDmdDcTihV5NDo0gdm3gAUsSTarRci2STgOJ95OWk0LK1o lvq5oEk6EAzge/U7u1mUEKnXjJ0jdMsomBER3G9sYj4TRGmG5mR7uF6XuWl7xNz+YVZL igDg== X-Forwarded-Encrypted: i=1; AJvYcCWr7jEo3KHvfDL/g1mY59AEMMWnPlfIXGh+2sPQL4O7rYt18MOtQuErDiKfp7fSC/y6QN6vjdfMLkicHtz3@vger.kernel.org X-Gm-Message-State: AOJu0Yyjoiyc8hwepfuEFnEPSW5YznXhZXSXHUpFPqDT4UovlRFHodXI gCFBJ0rrrRFW7v63d2I40cuax5/A+nY4iUOA3Br/P2s1BAcLQBhObUxV4RMdeqYcjcS/blPO+PT y+wSsBSgT78rUHVt8JbwVEGFOucQPfJaYTVo3wUh5FlT2yLR0CVXbTraYt/yFou7eOT0= X-Gm-Gg: ASbGncsDkYQlBgo3nkWo3WiLIsf9Avs64JSOJcO7HlTZ8zDVKMQeib+0y+TfjDvnWiq k0VVI2+UOmj8Zmj0QDrQlXS0iZ1pEje4n84kKhDftPUD/Zvqu84TVZJlV9zXbaMVU4t8YCbOFar DxZWTfqz4Ee6KsBWdmjihKo7P/+8ozKocq+BP+cX2SJ/zLGyaicidXWn/VVlIDyKkqDIGVNN+MJ 0DR0OyLTtdZSYo04ihq2aVa0YXhM1ojR1NmYe6zTOiKbSsvVoTEAMYwwYSWr/0alj583vYhTpDP CqDGu0G4uIvGhGj5gqMDyquyUVUmzypbwbk/YUxFHM552q1igRhYMR/XNM+qakaRAsSLN5EPW9O NUQutolSlQVJ21hb60by+AzT+SnLxNgpMbJH+BXPHdI1qv/TR/A== X-Received: by 2002:a05:6000:643:b0:3a6:d95e:f37c with SMTP id ffacd0b85a97d-3afa162e3eamr2592065f8f.2.1751386782451; Tue, 01 Jul 2025 09:19:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHLsheDAzVmPxelDGtXmBLJTIToWVZUdt5kz1Su7UknmC/bZ3D/wqAcBB9bZnWbrfYyDqyy5w== X-Received: by 2002:a05:6000:643:b0:3a6:d95e:f37c with SMTP id ffacd0b85a97d-3afa162e3eamr2592019f8f.2.1751386781923; Tue, 01 Jul 2025 09:19:41 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e52c8esm13813942f8f.55.2025.07.01.09.19.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 09:19:41 -0700 (PDT) Message-ID: Date: Tue, 1 Jul 2025 18:19:38 +0200 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 21/29] mm: rename PG_isolated to PG_movable_ops_isolated To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-22-david@redhat.com> <443de491-4ade-45f3-9c9b-b4428b0f0aaa@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <443de491-4ade-45f3-9c9b-b4428b0f0aaa@lucifer.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> PAGEFLAG(MovableOps, movable_ops, PF_NO_TAIL); >> +/* >> + * A movable_ops page has this flag set while it is isolated for migration. >> + * This flag primarily protects against concurrent migration attempts. >> + * >> + * Once migration ended (success or failure), the flag is cleared. The >> + * flag is managed by the migration core. >> + */ >> +PAGEFLAG(MovableOpsIsolated, movable_ops_isolated, PF_NO_TAIL); >> #else >> PAGEFLAG_FALSE(MovableOps, movable_ops); >> +PAGEFLAG_FALSE(MovableOpsIsolated, movable_ops_isolated); >> #endif > > Nit, but maybe worth sticking /* CONFIG_MIGRATION */ on else and endif? Not a > huge block so maybe not massively important but just a thought! Sure, why not (goes into the introducing patch) :) -- Cheers, David / dhildenb