From: cantabile <cantabile.desu@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: kubakici@wp.pl, gregkh@linuxfoundation.org,
akpm@linux-foundation.org, linux-wireless@vger.kernel.org,
keescook@chromium.org, shuah@kernel.org, mfuzzey@parkeon.com,
zohar@linux.vnet.ibm.com, dhowells@redhat.com,
pali.rohar@gmail.com, tiwai@suse.de,
arend.vanspriel@broadcom.com, zajec5@gmail.com, nbroeking@me.com,
markivx@codeaurora.org, stephen.boyd@linaro.org,
broonie@kernel.org, dmitry.torokhov@gmail.com,
dwmw2@infradead.org, torvalds@linux-foundation.org,
Abhay_Salunke@dell.com, bjorn.andersson@linaro.org,
jewalt@lgsinnovations.com, oneukum@suse.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [RFT 0/7] firmware: enable caching of firmware for reboot optimization
Date: Wed, 28 Feb 2018 23:18:49 +0200 [thread overview]
Message-ID: <b2f7e5b2-d937-528e-c4f8-58e275f60733@gmail.com> (raw)
In-Reply-To: <20180228184531.GK14069@wotan.suse.de>
On 28/02/18 20:45, Luis R. Rodriguez wrote:
> On Wed, Feb 28, 2018 at 08:03:26PM +0200, cantabile wrote:
>> On 28/02/18 01:20, Luis R. Rodriguez wrote:
>>> Cantabile, please give these patches a spin and let me know if it fixes
>>> your reported issue. They depend on other pending patches I have in line
>>> waiting to be merged so the easiest I thing I think is for you to test my
>>> 20180227-firmware-cache branch [0], based on Linus' tree. To get that
>>> tree, cd into your Linus git tree and do:
>>>
>>> git remote add mcgrof https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git
>>> git checkout -b 20180227-firmware-cache mcgrof/20180227-firmware-cache
>>>
>>> Please let me know if this resolves your issue and thanks for your report.
>>>
>>
>> I confirmed that request_firmware_cache is called, and the firmware is
>> loaded from the cache when resuming from hibernation. The bug is fixed.
>
> Great, thanks for testing.
>
> Curious, is it also called if you suspend to RAM instead of just using hibernation?
>
request_firmware_cache is called when resuming from suspend to RAM.
prev parent reply other threads:[~2018-02-28 21:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 23:20 [RFT 0/7] firmware: enable caching of firmware for reboot optimization Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 1/7] rename: _request_firmware_load() fw_load_sysfs_fallback() Luis R. Rodriguez
2018-02-27 23:28 ` Kees Cook
2018-02-28 1:21 ` Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 2/7] firmware: fix checking for return values for fw_add_devm_name() Luis R. Rodriguez
2018-02-27 23:29 ` Kees Cook
2018-02-28 1:19 ` Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 3/7] firmware: make fw_add_devm_name() return 0 if cache present Luis R. Rodriguez
2018-02-27 23:31 ` Kees Cook
2018-02-28 1:20 ` Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 4/7] firmware: add helper to check to see if fw cache is setup Luis R. Rodriguez
2018-02-27 23:20 ` [RFT 5/7] firmware: ensure the firmware cache is not used on incompatible calls Luis R. Rodriguez
2018-02-27 23:21 ` [RFT 6/7] firmware: add request_firmware_cache() to help with cache on reboot Luis R. Rodriguez
2018-02-27 23:21 ` [RFT 7/7] mt7601u: use request_firmware_cache() to address " Luis R. Rodriguez
2018-02-28 18:03 ` [RFT 0/7] firmware: enable caching of firmware for reboot optimization cantabile
2018-02-28 18:45 ` Luis R. Rodriguez
2018-02-28 21:18 ` cantabile [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2f7e5b2-d937-528e-c4f8-58e275f60733@gmail.com \
--to=cantabile.desu@gmail.com \
--cc=Abhay_Salunke@dell.com \
--cc=akpm@linux-foundation.org \
--cc=arend.vanspriel@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jewalt@lgsinnovations.com \
--cc=keescook@chromium.org \
--cc=kubakici@wp.pl \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=markivx@codeaurora.org \
--cc=mcgrof@kernel.org \
--cc=mfuzzey@parkeon.com \
--cc=nbroeking@me.com \
--cc=oneukum@suse.com \
--cc=pali.rohar@gmail.com \
--cc=shuah@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=tiwai@suse.de \
--cc=torvalds@linux-foundation.org \
--cc=zajec5@gmail.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).