From: Daniel Pinto <danielpinto52@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
ntfs3@lists.linux.dev, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 5/5] fs/ntfs3: rename hidedotfiles mount option to hide_dot_files
Date: Mon, 10 Oct 2022 12:37:13 +0100 [thread overview]
Message-ID: <b303dfee-4f3d-d21a-0e6b-5cf2c81b6fd9@gmail.com> (raw)
In-Reply-To: <9c404576-856b-6935-f2e3-c4d0749f16ea@gmail.com>
The hidedotfiles mount option provides the same functionality as
the NTFS-3G hide_dot_files mount option. As such, it should be
named the same for compatibility with NTGS-3G.
Rename the hidedotfiles to hide_dot_files for compatbility with
NTFS-3G.
Signed-off-by: Daniel Pinto <danielpinto52@gmail.com>
---
Documentation/filesystems/ntfs3.rst | 2 +-
fs/ntfs3/frecord.c | 2 +-
fs/ntfs3/inode.c | 2 +-
fs/ntfs3/super.c | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/Documentation/filesystems/ntfs3.rst b/Documentation/filesystems/ntfs3.rst
index fa03165f2310..4c6eb9fe9bea 100644
--- a/Documentation/filesystems/ntfs3.rst
+++ b/Documentation/filesystems/ntfs3.rst
@@ -75,7 +75,7 @@ this table marked with no it means default is without **no**.
- Files with the Windows-specific SYSTEM (FILE_ATTRIBUTE_SYSTEM) attribute
will be marked as system immutable files.
- * - hidedotfiles
+ * - hide_dot_files
- Updates the Windows-specific HIDDEN (FILE_ATTRIBUTE_HIDDEN) attribute
when creating and moving or renaming files. Files whose names start
with a dot will have the HIDDEN attribute set and files whose names
diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
index 41a20d71562a..552dbc5b80b1 100644
--- a/fs/ntfs3/frecord.c
+++ b/fs/ntfs3/frecord.c
@@ -3018,7 +3018,7 @@ int ni_add_name(struct ntfs_inode *dir_ni, struct ntfs_inode *ni,
struct ATTR_FILE_NAME *de_name = (struct ATTR_FILE_NAME *)(de + 1);
u16 de_key_size = le16_to_cpu(de->key_size);
- /* If option "hidedotfiles" then set hidden attribute for dot files. */
+ /* If option "hide_dot_files" then set hidden attribute for dot files. */
if (ni->mi.sbi->options->hide_dot_files) {
if (de_name->name_len > 0 &&
le16_to_cpu(de_name->name[0]) == '.')
diff --git a/fs/ntfs3/inode.c b/fs/ntfs3/inode.c
index e9cf00d14733..7ce2bb7646db 100644
--- a/fs/ntfs3/inode.c
+++ b/fs/ntfs3/inode.c
@@ -1272,7 +1272,7 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
fa = FILE_ATTRIBUTE_ARCHIVE;
}
- /* If option "hidedotfiles" then set hidden attribute for dot files. */
+ /* If option "hide_dot_files" then set hidden attribute for dot files. */
if (sbi->options->hide_dot_files && name->name[0] == '.')
fa |= FILE_ATTRIBUTE_HIDDEN;
diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c
index d796541e2a67..af67756998df 100644
--- a/fs/ntfs3/super.c
+++ b/fs/ntfs3/super.c
@@ -268,7 +268,7 @@ static const struct fs_parameter_spec ntfs_fs_parameters[] = {
fsparam_flag_no("force", Opt_force),
fsparam_flag_no("sparse", Opt_sparse),
fsparam_flag_no("hidden", Opt_nohidden),
- fsparam_flag_no("hidedotfiles", Opt_hide_dot_files),
+ fsparam_flag_no("hide_dot_files", Opt_hide_dot_files),
fsparam_flag_no("acl", Opt_acl),
fsparam_flag_no("showmeta", Opt_showmeta),
fsparam_flag_no("prealloc", Opt_prealloc),
@@ -562,7 +562,7 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root)
if (opts->nohidden)
seq_puts(m, ",nohidden");
if (opts->hide_dot_files)
- seq_puts(m, ",hidedotfiles");
+ seq_puts(m, ",hide_dot_files");
if (opts->force)
seq_puts(m, ",force");
if (opts->noacsrules)
next prev parent reply other threads:[~2022-10-10 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 11:27 [PATCH v2 0/5] fs/ntfs3: Fix and rename hidedotfiles mount option Daniel Pinto
2022-10-10 11:30 ` [PATCH v2 1/5] fs/ntfs3: fix hidedotfiles mount option by reversing behaviour Daniel Pinto
2022-10-10 11:32 ` [PATCH v2 2/5] fs/ntfs3: make hidedotfiles mount option work when renaming files Daniel Pinto
2022-10-10 11:34 ` [PATCH v2 3/5] fs/ntfs3: add hidedotfiles to the list of enabled mount options Daniel Pinto
2022-10-10 11:35 ` [PATCH v2 4/5] fs/ntfs3: document the hidedotfiles mount option Daniel Pinto
2022-10-10 11:37 ` Daniel Pinto [this message]
2022-11-12 18:18 ` [PATCH v2 0/5] fs/ntfs3: Fix and rename " Konstantin Komarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b303dfee-4f3d-d21a-0e6b-5cf2c81b6fd9@gmail.com \
--to=danielpinto52@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).