From mboxrd@z Thu Jan  1 00:00:00 1970
From: liu weni <qingshenlwy@gmail.com>
Subject: [PATCHv4 3/3]posix_acl: Add the acl pointer check
Date: Tue, 29 Dec 2009 07:37:02 +0800
Message-ID: <b3657a100912281537m3bc6b49euebdd75563d4b3cfb@mail.gmail.com>
References: <b3657a100912281534y7381a07evd076aabd3371b171@mail.gmail.com>
	 <b3657a100912281535x5e5f0ba4w67736250f1eebb5c@mail.gmail.com>
	 <b3657a100912281536s7a2ce33en2cae43889b99bfae@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
To: viro <viro@zeniv.linux.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S1752616AbZL1XhG@vger.kernel.org>
In-Reply-To: <b3657a100912281536s7a2ce33en2cae43889b99bfae@mail.gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

While the acl pointer is IS_ERR, We cannot get the correct return.

And the acl pointer is NULL. Oh, my god! The FOREACH_ACL_ENTRY will
call that.

---

Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org


---
diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index 39df95a..4e0261b 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -213,6 +213,12 @@ posix_acl_permission(struct inode *inode, const
struct posix_acl *acl, int want)
 	const struct posix_acl_entry *pa, *pe, *mask_obj;
 	int found = 0;

+	if (!acl)
+		return -EINVAL;
+
+	if (IS_ERR(acl))
+		return PTR_ERR(acl);
+
 	FOREACH_ACL_ENTRY(pa, acl, pe) {
                 switch(pa->e_tag) {
                         case ACL_USER_OBJ: