From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84718182C8 for ; Tue, 7 Nov 2023 13:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BGdBi/DF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40508C433C8; Tue, 7 Nov 2023 13:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699365342; bh=MezwdNposfNXG2orKfNEfaD6ELS73ydUqk05+JkokFc=; h=Date:To:Cc:References:From:Subject:In-Reply-To:From; b=BGdBi/DFC+qLlPIJwKRW1zKfsKHtJt/sHqj019yxcoFZemUY11tWCVltoekoxrv1s jPMtNaWWznziiOGpNBpCyWhwVPF93tz5COveJkuedJjWYWjuKEJq/Ur1QTo4ile0fF 2X7pB5mrhKsJxcbYlLyCRGZ8+CPOFjevhxBXyCAZAg9xQs0zMc0snrNHjzjt8w663y ExTwZ06jymVrM92JDbWCsbM0eeTSMSCB1hD7sjSETFlSu1kA9P/ddUghfx0FLKeIT2 Csrw1lAul8ydceYG8m6yMpunyctpj4/jeaVrGDmwG8U9Er0CLJWBPSXm4WwCjgQxtF fmZBwiD2YtZUQ== Message-ID: Date: Tue, 7 Nov 2023 21:55:37 +0800 Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Jan Kara , Al Viro Cc: linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Jaegeuk Kim References: <20231011203412.GA85476@ZenIV> <20231011215138.GX800259@ZenIV> <20231011230105.GA92231@ZenIV> <20231012050209.GY800259@ZenIV> <20231012103157.mmn6sv4e6hfrqkai@quack3> <20231012145758.yopnkhijksae5akp@quack3> <20231012191551.GZ800259@ZenIV> <20231017055040.GN800259@ZenIV> <20231026161653.cunh4ojohq6mw2ye@quack3> Content-Language: en-US From: Chao Yu Subject: Re: [RFC] weirdness in f2fs_rename() with RENAME_WHITEOUT In-Reply-To: <20231026161653.cunh4ojohq6mw2ye@quack3> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023/10/27 0:16, Jan Kara wrote: > Jaegeuk, Chao, any comment on this? It really looks like a filesystem > corruption issue in f2fs when whiteouts are used... Sorry for delay reply, I was busy handling product issues these days... Let me check this ASAP. Thanks, > > Honza > > On Tue 17-10-23 06:50:40, Al Viro wrote: >> [f2fs folks Cc'd] >> >> There's something very odd in f2fs_rename(); >> this: >> f2fs_down_write(&F2FS_I(old_inode)->i_sem); >> if (!old_dir_entry || whiteout) >> file_lost_pino(old_inode); >> else >> /* adjust dir's i_pino to pass fsck check */ >> f2fs_i_pino_write(old_inode, new_dir->i_ino); >> f2fs_up_write(&F2FS_I(old_inode)->i_sem); >> and this: >> if (old_dir != new_dir && !whiteout) >> f2fs_set_link(old_inode, old_dir_entry, >> old_dir_page, new_dir); >> else >> f2fs_put_page(old_dir_page, 0); >> The latter really stinks, especially considering >> struct dentry *f2fs_get_parent(struct dentry *child) >> { >> struct page *page; >> unsigned long ino = f2fs_inode_by_name(d_inode(child), &dotdot_name, &page); >> >> if (!ino) { >> if (IS_ERR(page)) >> return ERR_CAST(page); >> return ERR_PTR(-ENOENT); >> } >> return d_obtain_alias(f2fs_iget(child->d_sb, ino)); >> } >> >> You want correct inumber in the ".." link. And cross-directory >> rename does move the source to new parent, even if you'd been asked >> to leave a whiteout in the old place. >> >> Why is that stuff conditional on whiteout? AFAICS, that went into the >> tree in the same commit that added RENAME_WHITEOUT support on f2fs, >> mentioning "For now, we just try to follow the way that xfs/ext4 use" >> in commit message. But ext4 does *NOT* do anything of that sort - >> at the time of that commit the relevant piece had been >> if (old.dir_bh) { >> retval = ext4_rename_dir_finish(handle, &old, new.dir->i_ino); >> and old.dir_bh is set by >> retval = ext4_rename_dir_prepare(handle, &old); >> a few lines prior, which is not conditional upon the whiteout. >> >> What am I missing there?