From: Jeff Layton <jlayton@kernel.org>
To: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Cc: Christian Brauner <brauner@kernel.org>,
Al Viro <viro@ZenIV.linux.org.uk>
Subject: Re: [PATCH] sysv: Remove the filesystem
Date: Mon, 06 Jan 2025 14:52:11 -0500 [thread overview]
Message-ID: <b4a292ba5a33cc5d265a46824057fe001ed2ced6.camel@kernel.org> (raw)
In-Reply-To: <20250106162401.21156-1-jack@suse.cz>
On Mon, 2025-01-06 at 17:24 +0100, Jan Kara wrote:
> Since 2002 (change "Replace BKL for chain locking with sysvfs-private
> rwlock") the sysv filesystem was doing IO under a rwlock in its
> get_block() function (yes, a non-sleepable lock hold over a function
> used to read inode metadata for all reads and writes). Nobody noticed
> until syzbot in 2023 [1]. This shows nobody is using the filesystem.
> Just drop it.
>
> [1] https://lore.kernel.org/all/0000000000000ccf9a05ee84f5b0@google.com/
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
> What do people think about this? Or should we perhaps go through a (short)
> deprecation period where we warn about removal?
>
FWIW, it was orphaned in 2023:
commit a8cd2990b694ed2c0ef0e8fc80686c664b4ebbe5
Author: Christoph Hellwig <hch@lst.de>
Date: Thu Feb 16 07:29:22 2023 +0100
orphan sysvfs
This code has been stale for years and I have no way to test it.
Given how long this was broken with no one noticing, and since it's not
being adequately tested, I vote we remove it.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-01-06 19:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 16:24 [PATCH] sysv: Remove the filesystem Jan Kara
2025-01-06 19:52 ` Jeff Layton [this message]
2025-01-06 23:31 ` Darrick J. Wong
2025-01-07 7:17 ` Cedric Blancher
2025-01-07 10:08 ` Jan Kara
2025-01-07 15:13 ` Al Viro
2025-01-06 20:41 ` Matthew Wilcox
2025-01-07 14:35 ` Christian Brauner
2025-01-08 22:32 ` Bill O'Donnell
2025-01-09 15:05 ` Christian Brauner
2025-01-09 23:08 ` Bill O'Donnell
-- strict thread matches above, loose matches on Subject: below --
2025-02-20 16:39 Jan Kara
2025-02-20 18:50 ` Darrick J. Wong
2025-02-20 20:06 ` Jeff Layton
2025-02-21 9:38 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4a292ba5a33cc5d265a46824057fe001ed2ced6.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox