linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Tamir Duberstein <tamird@gmail.com>,
	Matthew Wilcox <willy@infradead.org>
Cc: Jonathan Corbet <corbet@lwn.net>,
	linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] XArray: minor documentation improvements
Date: Wed, 9 Oct 2024 15:22:02 -0700	[thread overview]
Message-ID: <b4a4668d-1280-446e-b1a9-a01fd073fd8f@infradead.org> (raw)
In-Reply-To: <20241009205237.48881-2-tamird@gmail.com>



On 10/9/24 1:52 PM, Tamir Duberstein wrote:
> - Replace "they" with "you" where "you" is used in the preceding
>   sentence fragment.
> - Use "erasing" rather than "storing `NULL`" when describing multi-index
>   entries. Split this into a separate sentence.
> - Add "call" parentheses on "xa_store" for consistency and
>   linkification.
> 
> Signed-off-by: Tamir Duberstein <tamird@gmail.com>
> ---
> V1 -> V2: s/use/you/ (Darrick J. Wong)
> 
>  Documentation/core-api/xarray.rst | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/core-api/xarray.rst b/Documentation/core-api/xarray.rst
> index 77e0ece2b1d6..75c83b37e88f 100644
> --- a/Documentation/core-api/xarray.rst
> +++ b/Documentation/core-api/xarray.rst

> @@ -52,8 +52,8 @@ An unusual feature of the XArray is the ability to create entries which
>  occupy a range of indices.  Once stored to, looking up any index in
>  the range will return the same entry as looking up any other index in
>  the range.  Storing to any index will store to all of them.  Multi-index
> -entries can be explicitly split into smaller entries, or storing ``NULL``

Is storing %NULL does by making a function call or just by doing
	*xa1 = NULL;

?

> -into any entry will cause the XArray to forget about the range.
> +entries can be explicitly split into smaller entries. Erasing any entry
> +will cause the XArray to forget about the range.

Clearing any entry by calling xa_erase() will cause the XArray to forget about the range.


>  
>  Normal API
>  ==========


-- 
~Randy

  parent reply	other threads:[~2024-10-09 22:22 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-09 19:36 [PATCH] XArray: minor documentation improvements Tamir Duberstein
2024-10-09 20:44 ` Darrick J. Wong
2024-10-09 20:51   ` Tamir Duberstein
2024-10-09 20:52     ` [PATCH v2] " Tamir Duberstein
2024-10-09 21:25       ` Darrick J. Wong
2024-10-09 21:59       ` Jonathan Corbet
2024-10-09 22:16         ` Tamir Duberstein
2024-10-09 22:22       ` Randy Dunlap [this message]
2024-10-10 14:11         ` Tamir Duberstein
2024-10-10 14:12           ` [PATCH v3] " Tamir Duberstein
2024-10-10 21:34             ` Randy Dunlap
2024-10-10 21:39               ` Tamir Duberstein
2024-10-10 21:41                 ` [PATCH v4] " Tamir Duberstein
2024-10-10 21:50                   ` Randy Dunlap
2024-10-10 22:41                     ` Matthew Wilcox
2024-10-16 12:51                       ` Tamir Duberstein
2024-10-24 19:52                         ` Tamir Duberstein
2024-10-17  0:34                   ` Bagas Sanjaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b4a4668d-1280-446e-b1a9-a01fd073fd8f@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tamird@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).