From: David Hildenbrand <david@redhat.com>
To: Zi Yan <ziy@nvidia.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Yang Shi <shy828301@gmail.com>, Yu Zhao <yuzhao@google.com>,
linux-mm@kvack.org
Cc: "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Ryan Roberts" <ryan.roberts@arm.com>,
"Michal Koutný" <mkoutny@suse.com>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Zach O'Keefe" <zokeefe@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 5/7] mm: thp: split huge page to any lower order pages.
Date: Tue, 8 Aug 2023 11:01:19 +0200 [thread overview]
Message-ID: <b545cac8-76f7-e3c3-0e1c-3cb922c9c9ae@redhat.com> (raw)
In-Reply-To: <20230329011712.3242298-6-zi.yan@sent.com>
On 29.03.23 03:17, Zi Yan wrote:
> From: Zi Yan <ziy@nvidia.com>
>
> To split a THP to any lower order pages, we need to reform THPs on
> subpages at given order and add page refcount based on the new page
> order. Also we need to reinitialize page_deferred_list after removing
> the page from the split_queue, otherwise a subsequent split will see
> list corruption when checking the page_deferred_list again.
>
> It has many uses, like minimizing the number of pages after
> truncating a huge pagecache page. For anonymous THPs, we can only split
> them to order-0 like before until we add support for any size anonymous
> THPs.
>
Because I'm currently looking into something that would also not be
compatible with order-1 for now:
You should make it clear that order-1 is not supported, like:
"mm: thp: split huge page to any lower order pages (except order 1)"
And clarify in the subject why that is the case.
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2023-08-08 18:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-29 1:17 [PATCH v2 0/7] Split a folio to any lower order folios Zi Yan
2023-03-29 1:17 ` [PATCH v2 1/7] mm/memcg: use order instead of nr in split_page_memcg() Zi Yan
2023-03-29 1:17 ` [PATCH v2 2/7] mm/page_owner: use order instead of nr in split_page_owner() Zi Yan
2023-03-29 1:17 ` [PATCH v2 3/7] mm: memcg: make memcg huge page split support any order split Zi Yan
2023-03-29 1:17 ` [PATCH v2 4/7] mm: page_owner: add support for splitting to any order in split page_owner Zi Yan
2023-03-29 9:58 ` kernel test robot
2023-03-29 13:16 ` Zi Yan
2023-03-29 14:48 ` kernel test robot
2023-03-29 16:11 ` kernel test robot
2023-03-29 1:17 ` [PATCH v2 5/7] mm: thp: split huge page to any lower order pages Zi Yan
2023-08-08 9:01 ` David Hildenbrand [this message]
2023-08-08 14:45 ` Zi Yan
2023-03-29 1:17 ` [PATCH v2 6/7] mm: truncate: split huge page cache page to a non-zero order if possible Zi Yan
2023-03-29 1:17 ` [PATCH v2 7/7] mm: huge_memory: enable debugfs to split huge pages to any order Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b545cac8-76f7-e3c3-0e1c-3cb922c9c9ae@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mkoutny@suse.com \
--cc=roman.gushchin@linux.dev \
--cc=ryan.roberts@arm.com \
--cc=shy828301@gmail.com \
--cc=willy@infradead.org \
--cc=yuzhao@google.com \
--cc=ziy@nvidia.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).