* [PATCH] vboxsf: Remove the unused variable out_len
@ 2023-10-11 2:53 Jiapeng Chong
2023-10-11 6:34 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2023-10-11 2:53 UTC (permalink / raw)
To: hdegoede; +Cc: linux-fsdevel, linux-kernel, Jiapeng Chong, Abaci Robot
Variable out_len is not effectively used, so delete it.
fs/vboxsf/utils.c:443:9: warning: variable 'out_len' set but not used
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6776
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
fs/vboxsf/utils.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
index 72ac9320e6a3..9515bbf0b54c 100644
--- a/fs/vboxsf/utils.c
+++ b/fs/vboxsf/utils.c
@@ -440,7 +440,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
{
const char *in;
char *out;
- size_t out_len;
size_t out_bound_len;
size_t in_bound_len;
@@ -448,7 +447,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
in_bound_len = utf8_len;
out = name;
- out_len = 0;
/* Reserve space for terminating 0 */
out_bound_len = name_bound_len - 1;
@@ -469,7 +467,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
out += nb;
out_bound_len -= nb;
- out_len += nb;
}
*out = 0;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] vboxsf: Remove the unused variable out_len
2023-10-11 2:53 [PATCH] vboxsf: Remove the unused variable out_len Jiapeng Chong
@ 2023-10-11 6:34 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2023-10-11 6:34 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: linux-fsdevel, linux-kernel, Abaci Robot
Hi,
On 10/11/23 04:53, Jiapeng Chong wrote:
> Variable out_len is not effectively used, so delete it.
>
> fs/vboxsf/utils.c:443:9: warning: variable 'out_len' set but not used
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=6776
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> fs/vboxsf/utils.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/vboxsf/utils.c b/fs/vboxsf/utils.c
> index 72ac9320e6a3..9515bbf0b54c 100644
> --- a/fs/vboxsf/utils.c
> +++ b/fs/vboxsf/utils.c
> @@ -440,7 +440,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
> {
> const char *in;
> char *out;
> - size_t out_len;
> size_t out_bound_len;
> size_t in_bound_len;
>
> @@ -448,7 +447,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
> in_bound_len = utf8_len;
>
> out = name;
> - out_len = 0;
> /* Reserve space for terminating 0 */
> out_bound_len = name_bound_len - 1;
>
> @@ -469,7 +467,6 @@ int vboxsf_nlscpy(struct vboxsf_sbi *sbi, char *name, size_t name_bound_len,
>
> out += nb;
> out_bound_len -= nb;
> - out_len += nb;
> }
>
> *out = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-11 6:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-11 2:53 [PATCH] vboxsf: Remove the unused variable out_len Jiapeng Chong
2023-10-11 6:34 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).